Repository navigation
chore: add joint index after SQL issue on toolforge - #172
Merged
Merged
Conversation
An index was created in production manually. This adds the corresponding migration. The migration should be faked (with `./manage.py migrate --fake`) on instances where it was already created, and applied normally (`./manage.py migrate`) on others. See https://phabricator.wikimedia.org/T438504.
Member
Author
|
The CI failure seems to be independent of the change, @arcstur. It probably fails on the master branch as well (looks like dependency versions aren't properly pinned, maybe we finally need a lockfile) |
Member
|
Great, thank you @wetneb . For dependency management, do you have any opinions? As the python ecosystem is pretty diffuse on that. Maybe poetry? Or uv? |
Member
Author
|
uv seems to be the new norm, but I'm far from an expert! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An index was created in production manually. This adds the corresponding migration. The migration should be faked (with
./manage.py migrate --fake) on instances where it was already created, and applied normally (./manage.py migrate) on others.See https://phabricator.wikimedia.org/T438504.