chore: remove unused WebClient rate-limit recording path - #252
Open
detail-app[bot] wants to merge 2 commits into
Open
chore: remove unused WebClient rate-limit recording path#252detail-app[bot] wants to merge 2 commits into
detail-app[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove RateLimitService.recordRateLimitFromException and its only helper
RateLimitDecisionResolver.resolveFromWebClientException, along with the
WebClientResponseException imports and the two RateLimitServiceTest cases
that exercised the removed behavior.
The last production caller (ResilientApiClient) was deleted when the
OpenAI SDK integration replaced it (commit 1690399), leaving
recordRateLimitFromException referenced only from RateLimitServiceTest.
resolveFromWebClientException had no other callers and was reachable only
through the now-removed public method.
History
Dead Code PRs can be configured here.