Gamepad identity fixes - #727
Open
sl1nk3 wants to merge 9 commits into
Open
Conversation
… not being recognized, fixed by spoofing an Xbox 360 Controller instead. Added a new setting to allow external gamepad to advertise their real device name and product ids (this can for example be enabled if a Dualshock gamepad is connected and the game you're plyaing has custom layout or playstation icons when a PS controller is connected)
…gle, which makes more sense and hides it when not relevant
…d use the pref manager
… product id is for some reason overwritten by the device mapper
Contributor
|
checking this out later today, sounds awesome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Many games (e.g. The Stanley Parable Ultra Deluxe, Kingdom Hearts, and others) have basic gamepad support where the buttons layout is hardcoded for specific controllers like Xbox and Playstation controllers. WinNative was advertising all gamepads as "Generic HID Gamepad" with fake vendor/product IDs (0x1234/0x5678), which broke recognition in these games.
Fix
This branch makes two changes:
Tested locally on an AYN Thor with a Xbox One gamepad over bluetooth as well as a Playstation 3 controller.