misc fixes & device resolutions - #728
Merged
Merged
Conversation
Change Container.DEFAULT_AUDIO_DRIVER to pulseaudio and append WINE_FAST_YIELD=1 to Container.DEFAULT_ENV_VARS, so the setup wizard and the manual create dialog both inherit them. Duplication copies the source config wholesale, so apply the same two defaults to the copied JSON before it is loaded. Exclude WINE_FAST_YIELD from the appVersion < 16 env var backfill so existing containers keep their current environment.
Duplication should carry over the source container's own audio driver and environment variables, so drop the forced defaults from that path. The new defaults still apply to the setup wizard and the manual create dialog via Container.DEFAULT_AUDIO_DRIVER and Container.DEFAULT_ENV_VARS.
Show Device Resolutions replaces the fixed 16:9 / 4:3 list with each standard tier (360p through 4K, capped at the panel) recomputed for this screen's own aspect ratio, plus the panel's native resolution. Entries are always landscape: the panel size is normalised to long side by short side regardless of rotation, and any entry that would come out narrower than it is tall is dropped. Every dimension is rounded to an even number, matching the custom width and height fields. The toggle is a global preference shared by the container editor and the shortcut editor, both of which render the same General section. Flipping it keeps the current resolution when the list has it, otherwise snaps to the entry of the same tier height, otherwise falls back to Custom with the width and height preserved.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Turkish and Brazilian Portuguese label capitalisation now follows the neighbouring Screen Size and Audio Driver labels, Hindi ends the help sentence with a danda like the rest of that file, and the German help text says schwarzen Balken rather than just Balken.
A global preference meant turning it on in one container turned it on in every other one. It is now the container extra showDeviceResolutions, written on save alongside swapRB and the frame-gen extras, and read back from the container being edited. Shortcuts follow the same inheritance as every other shortcut field: the owning container's value unless the shortcut saves its own override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.