Add channels and sriov_vf_channels interface configuration support - #560
Merged
Conversation
Collaborator
Author
|
Depends on: Wind-River/gophercloud#54 |
wasnio
force-pushed
the
feat/channels
branch
2 times, most recently
from
August 10, 2026 18:11
3364cc4 to
059aace
Compare
Add support for configuring NIC channels (queues) on interfaces via two new parameters: - channels (pfChannels): configures the number of combined channels on ethernet and ae (bond) type interfaces. Must be >= 1 and <= the port's maxchannels. - sriov_vf_channels (vfChannels): configures the number of SR-IOV VF channels on pci-sriov classed interfaces with vf-driver set to netdevice, or on vf type interfaces. Must be >= 1 and <= the port's sriov_vf_maxchannels. Test Plan: - Deploy AIO-SX/Standard system with channels configured on platform ethernet and pci-sriov ethernet interfaces - Verify channels value is applied via system host-if-show - Deploy VF interface with vfDriver=netdevice and sriov_vf_channels configured, verify value is applied - Run deployctl build and confirm generated YAML includes pfChannels and vfChannels fields with correct values - Verify webhook rejects sriov_vf_channels on interfaces without vf-driver set to netdevice Signed-off-by: Wallysson <wallysson.silva@windriver.com>
yjian118
reviewed
Aug 10, 2026
yjian118
left a comment
Collaborator
There was a problem hiding this comment.
What if we create a SR-IOV w/o the vfChannels configuration? Will it block the interface update? If the sysinv block it when interface update, then I'm afraid we'll need to handle it in the dm or update existing configuration to avoid massive failure in the labs
Collaborator
Author
|
@yjian118 if channel isn't in the configuration, dm won't send it to sysinv. |
yjian118
approved these changes
Aug 11, 2026
enzocandotti
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for configuring NIC channels (queues) on interfaces via
two new parameters:
channels (pfChannels): configures the number of combined channels
on ethernet and ae (bond) type interfaces. Must be >= 1 and <= the
port's maxchannels.
sriov_vf_channels (vfChannels): configures the number of SR-IOV VF
channels on pci-sriov classed interfaces with vf-driver set to
netdevice, or on vf type interfaces. Must be >= 1 and <= the port's
sriov_vf_maxchannels.