Skip to content

Add channels and sriov_vf_channels interface configuration support - #560

Merged
enzocandotti merged 1 commit into
Wind-River:masterfrom
wasnio:feat/channels
Aug 11, 2026
Merged

Add channels and sriov_vf_channels interface configuration support#560
enzocandotti merged 1 commit into
Wind-River:masterfrom
wasnio:feat/channels

Conversation

@wasnio

@wasnio wasnio commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Add support for configuring NIC channels (queues) on interfaces via
two new parameters:

  • channels (pfChannels): configures the number of combined channels
    on ethernet and ae (bond) type interfaces. Must be >= 1 and <= the
    port's maxchannels.

  • sriov_vf_channels (vfChannels): configures the number of SR-IOV VF
    channels on pci-sriov classed interfaces with vf-driver set to
    netdevice, or on vf type interfaces. Must be >= 1 and <= the port's
    sriov_vf_maxchannels.

Test Plan:
- Deploy AIO-SX/Standard system with channels configured on
  platform ethernet and pci-sriov ethernet interfaces
- Verify channels value is applied via system host-if-show
- Deploy VF interface with vfDriver=netdevice and sriov_vf_channels
  configured, verify value is applied
- Run deployctl build and confirm generated YAML includes
  pfChannels and vfChannels fields with correct values
- Verify webhook rejects sriov_vf_channels on interfaces without
  vf-driver set to netdevice

@wasnio wasnio changed the title WIP: add channels configuration to interface Add channels and sriov_vf_channels interface configuration support Aug 7, 2026
@wasnio
wasnio requested review from enzocandotti and yjian118 August 7, 2026 13:24
@wasnio

wasnio commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

Depends on: Wind-River/gophercloud#54

@wasnio
wasnio force-pushed the feat/channels branch 2 times, most recently from 3364cc4 to 059aace Compare August 10, 2026 18:11
Add support for configuring NIC channels (queues) on interfaces via
two new parameters:

- channels (pfChannels): configures the number of combined channels
  on ethernet and ae (bond) type interfaces. Must be >= 1 and <= the
  port's maxchannels.

- sriov_vf_channels (vfChannels): configures the number of SR-IOV VF
  channels on pci-sriov classed interfaces with vf-driver set to
  netdevice, or on vf type interfaces. Must be >= 1 and <= the port's
  sriov_vf_maxchannels.

Test Plan:
- Deploy AIO-SX/Standard system with channels configured on
  platform ethernet and pci-sriov ethernet interfaces
- Verify channels value is applied via system host-if-show
- Deploy VF interface with vfDriver=netdevice and sriov_vf_channels
  configured, verify value is applied
- Run deployctl build and confirm generated YAML includes
  pfChannels and vfChannels fields with correct values
- Verify webhook rejects sriov_vf_channels on interfaces without
  vf-driver set to netdevice

Signed-off-by: Wallysson <wallysson.silva@windriver.com>

@yjian118 yjian118 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we create a SR-IOV w/o the vfChannels configuration? Will it block the interface update? If the sysinv block it when interface update, then I'm afraid we'll need to handle it in the dm or update existing configuration to avoid massive failure in the labs

Comment thread internal/webhook/v1/hostprofile_webhook.go
@wasnio

wasnio commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

@yjian118 if channel isn't in the configuration, dm won't send it to sysinv.

@wasnio
wasnio requested a review from yjian118 August 11, 2026 10:33
@enzocandotti
enzocandotti merged commit 2ddfaa7 into Wind-River:master Aug 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants