Translate ticket and branch notices and input errors

[ryanwelcher]

Why

The ticket card's questions and notices, the merge-in-progress and legacy-site notices, the deep-link banners, the folder-open failures, and the input errors for a ticket or issue number were plain English in a translated window. This is the #629 batch of #622, and needed the catalog in main from #634.

What changes

• Whole sentences, per kind. Every sentence that spliced in a noun (ticket/issue), an English article, or a count is now one string per kind of work item, with _n for counts. This covers the dirty-trunk question (ticket-actions.cjs), the trunk-moved notice and the move's refusals (ticket-trunk-notice.cjs), the changes note (changes-note.cjs), and the carried-work notice in index.jsx.
• The changes note used to be lead / link / middle / link / end. It is now one sentence per case with <review> and <discard> marked in it, filled in by createInterpolateElement. DiscardChangesLink takes its words as children for that.
• Constants became functions: LEGACY_SITE_ERROR → legacySiteError(), DISCARD_CONFIRM_MESSAGE → discardConfirmMessage(), and the merge kinds table → kindWords(kind). Git commands go in as %s; the "resolve the files, then git add them and run %s" frame and the <every file the patch touched…> placeholder are wrapped.
• Main process: the ticket and issue parsers' refusals (main returns them), the ticket-branches.js errors that reach res.error, the rebase handler's three refusals and the dirty-trunk error in main.js, and the editor's exit-code error in editor-launch.js.
• @wordpress/element becomes a direct dependency, the same line Translate the Review & submit dialog #635 and Translate the pull request destination and GitHub sign-in #643 add.

Not wrapped, per #622: the WIP commit message, which leaves the app.

How to test this

The new journeys in tests/e2e/journeys/i18n.spec.js walk every state #629 lists, in the pseudo-locale. Run them from the repository root on either platform:

npx playwright test --project=journeys tests/e2e/journeys/i18n.spec.js -g "ticket card's questions|ticket from a link|merge left open|folder will not open"

All five fail without this change (checked by putting trunk's src/ back and rebuilding). They cover: a refused ticket number; loose edits on trunk and the question about them; both discard confirmations (read from window.confirm, since Electron's are not Playwright dialogs); the carried notice and the changes note with its two links; a parked ticket whose trunk moved; edits saved before a clean start; a deep link with no site, on a Core site and on a Gutenberg site; a merge left open by a terminal; a legacy site; and editor:open and dir:show stubbed to return each reason.

What the journeys cannot reach: the main-process refusals that need a real Git failure (the move's conflict, "No such branch", a second branch for the same issue) and the editor's exit code. Unit tests add the pseudo-locale filter and check those: ticket-branches.integration, editor-launch, trac-ticket, github-issue, merge-in-progress, legacy-site and ticket-trunk-notice.

To see the card by hand (either platform, current head):

1. From the repository root, run npx electron . --lang=en-XA.
2. Open a Core site on trunk, edit src/wp-login.php, type a ticket number in the ticket field and click Link ticket.
   • Expected: the question and its four buttons are accented and in brackets.
3. Click the button that takes the edits into the ticket.
   • Expected: the carried notice and the changes note under the ticket are accented and in brackets. The note's two links are accented words inside its sentence.

What must not have happened: no English an English speaker sees has changed. The full journey suite (129, including ticket-branches, ticket-rebase, merge-in-progress, legacy-site, gutenberg-site, site-header, review-changes and trunk-update) passes with its exact English strings, and the unit tests that pin whole English sentences pass unchanged.

Risks and limitations

• Other open batches also append tests to the end of i18n.spec.js: Translate the pull request destination and GitHub sign-in #643, Translate the Review & submit dialog #635 and Translate the setup checklist and the trunk update banners #636, and the parallel Translate the Terminal and Logs output #627 and Translate patch and pull request apply failures #628. Whichever merges later resolves that by keeping both. This branch carries the same unwrapped() scanner hunk as Translate the pull request destination and GitHub sign-in #643 and Translate the Review & submit dialog #635, byte for byte, so that part merges cleanly.

• Translate the Review & submit dialog #635 adds an @wordpress/i18n require to changes-note.cjs on the same line this branch does, and Translate the setup checklist and the trunk update banners #636 edits use-trunk-update.jsx and the @wordpress/i18n import in index.jsx. The index.jsx import line is identical to Translate the setup checklist and the trunk update banners #636's. The others are small conflicts for whichever merges second.

• Two English sentences changed in states the app cannot reach: rebaseRefusal with no ticket number used to say "link #the ticket again" and "which trunk #the ticket started from". They now say "the ticket". The card only offers the move when a ticket is linked.

• Kept as they were: a few strings still say "ticket" on a Gutenberg site, as they did before (the merge and legacy notices' "linking tickets", main's dirty-trunk and rebase errors, "Could not save the ticket."). Each is wrapped whole, not reworded. Main's rebase errors are replaced by the card's own per-kind wording before display.

• Not wrapped, because nothing shows them: ticket-branches.js's refusals to commit on trunk, to switch with uncommitted trunk work (dirty-trunk, asked as a question instead), and its own no-base error (worded by the card from the code).

• The dirty-trunk question is two whole sentences joined with a space, as the merge refusal already joins its title and body.

• Review: 1 [fix here] (fixed) and 1 [follow-up] (deferred, below).

• Deferred follow-up: the carried-work notice still picks its plural inside index.jsx, where the unit suite cannot reach it. It was a ternary there before, and Translate ticket and branch notices and input errors #629 asks for this rewrite at this spot. Moving it into a .cjs helper beside dirtyTrunkQuestion would make both forms testable.

Related

Fixes #629. Part of #622.

---

Design decisions and alternatives considered

• The changes note returns one marked-up string rather than the five parts. The parts fixed English word order around the two links; one sentence with <review> and <discard> lets a translator move them.
• The Trac and GitHub hosts and the repository go in as %s, as Wrap the rest of the app's strings for translation #622 asks for product names and keys.
• The merge restore placeholder keeps its angle brackets outside the translated words (<%s>), so the pseudo-locale accents the words and a translator does not have to keep the brackets.
• The journeys use their own require lines at the end of the file rather than editing the shared one at the top, so they do not conflict with the other batches' edits to it.

Review outcome (required — see AGENTS.md)

1 [fix here] · 1 [follow-up]. The [fix here] is fixed; the follow-up is deferred (see Risks).

• 🔵 Tests: the issue variants of the dirty-trunk question had no test that pinned them whole. Fixed: tests/unit/ticket-actions.test.cjs now pins each one with an exact assert.equal.

• 🔵 Architecture, [follow-up]: the carried-work notice's plural is decided in index.jsx. It was decided there before this PR too. Deferred.

• The reviewer compared old and new output by hand for every module in the diff and found no reachable English change. It noted that the unreachable no-ticket wording of rebaseRefusal changed, which is listed in Risks.

• Review: completed. Fresh read-only agent context, head 126b51e / base 9fd167e, all 27 files. Before it: npm run lint clean, npm test 2039 pass / 0 fail / 2 skipped, npm run i18n:pot clean with every translator comment in the .pot, full journey suite 129 pass.

• Since review: 126b51e → 0bb2fa3 added the test for the [fix here] finding. Then 0bb2fa3 → 149ff18, rebased onto trunk at e94f507 (base e94f507) after Translate the Review & submit dialog #635 merged. The rebase resolved two conflicts: changes-note.cjs's @wordpress/i18n import now takes _n alongside Translate the Review & submit dialog #635's __ and sprintf, and the journeys appended to i18n.spec.js now follow Translate the Review & submit dialog #635's, using trunk's gitOk import. The scanner hunk and the @wordpress/element line were already on trunk, so the branch's copies dropped out. Checked by the authoring session, not re-reviewed by a fresh context: npm run lint clean, npm test 2041 pass / 0 fail / 2 skipped, npm run i18n:pot clean, full journey suite 135 pass.

Screenshots or recording

None. Nothing changes on screen in English, and the pseudo-locale journeys are the check for the translated state.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: WordPress/contributor-toolkit/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 50847494-6091-4016-b362-75d50efefdea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}