Repository navigation
Fix ambiguous link texts by removing redundant post date links and adding screen reader text to comments CTA - #93
Conversation
…dding screen reader text to comments CTA
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test ReportPatch tested: #93 (commit ea1bd81) Environment
Steps
Results
Expected resultPost dates in the query loops are shown as plain text, not links. Every link in the post list has a unique accessible name. The visible design stays the same, apart from the date no longer being underlined as a link. Result: as expected on all tested templates. Note: the branch currently conflicts with trunk in |
Resolves the conflict in archive-columns.php, where trunk no longer wraps the date in a group, by keeping trunk's markup and dropping the date link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Unlink the post dates in archive-lead and page-blog-home, which landed after WordPress#93. - Unlink comment dates. The block links them by default, so comments from the same day shared a link name. - Keep the comment avatar in the same tab. Its new-tab warning was only in an aria-label, so sighted visitors got none. - Strip tags from the post title in the comments CTA's screen reader text, so titles with markup aren't read with their tags. Part of WordPress#44. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
I took this over to make a few changes:
|
Description
Fixes #47
As identified in #47 during accessibility-ready verification for the theme, multiple links across post query loops lacked unique accessible names:
Redundant Post Date Links: On index, archive, search, and single patterns, the post date block previously linked to the post (
"isLink":true). With the featured image and post title already serving as links to the post, linked post dates resulted in duplicate link targets with non-unique accessible names when multiple posts were published on the same day. Following discussion on the issue and theme developer guidelines,"isLink":truehas been removed fromcore/post-dateacross patterns, keeping dates purely as semantic informational<time>elements.Comments CTA Block Binding: The
ipsum/comments-ctablock binding renders call-to-action links ("Join the conversation" and "Be the first to comment"). When multiple posts appear in the loop, screen readers encounter identical link text pointing to different destinations. This pull request adds contextual screen reader text with the post title (<span class="screen-reader-text"> on %s</span>), aligning with WordPress Core's bundledcore/post-comments-linkstandard (No comments<span class="screen-reader-text"> on %s</span>).Screenshots
N/A — Structural accessibility enhancement. Visual appearance on screen remains identical, while screen readers and assistive technology receive unambiguous link names.
Testing Instructions
<span class="screen-reader-text"> on [Post Title]</span>, ensuring unique and informative accessible names for assistive technology.