Repository navigation
Make link names unique and keep comment avatars in the same tab - #144
Closed
MaggieCabrera wants to merge 2 commits into
Closed
MaggieCabrera wants to merge 2 commits into
MaggieCabrera wants to merge 2 commits into
Conversation
- Unlink the post dates in archive-lead and page-blog-home, which landed after #93. - Unlink comment dates. The block links them by default, so comments from the same day shared a link name. - Keep the comment avatar in the same tab. Its new-tab warning was only in an aria-label, so sighted visitors got none. - Strip tags from the post title in the comments CTA's screen reader text, so titles with markup aren't read with their tags. Part of #44. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on #93 by @noruzzamans. Its commit is included here, rebased on trunk. Fixes #47 and is part of #44.
archive-leadandpage-blog-home, which landed after Fix ambiguous link texts by removing redundant post date links and adding screen reader text to comments CTA #93. Removing the links follows what we agreed on in Fix: Add unique accessible names to post-date and Comments CTA links #54.aria-label, and the accessibility-ready guideline asks for a warning sighted visitors can see too.Screenshots
Testing Instructions
Checked on the front end, in the Site Editor, and with the Blue Hour and Evening variations.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: The accessibility audit, rebasing #93 onto trunk, the follow-up changes and this description.
🤖 Generated with Claude Code