Skip to content

Make link names unique and keep comment avatars in the same tab - #144

Closed
MaggieCabrera wants to merge 2 commits into
trunkfrom
claude/jolly-hawking-013a72
Closed

MaggieCabrera wants to merge 2 commits into
trunkfrom
claude/jolly-hawking-013a72

Conversation

@MaggieCabrera

Copy link
Copy Markdown
Contributor

Description

Builds on #93 by @noruzzamans. Its commit is included here, rebased on trunk. Fixes #47 and is part of #44.

Screenshots

Testing Instructions

  1. Import the accessibility test content, or add a few posts on the same day and a post with comments.
  2. On the blog home, a category archive and the search results, check that dates are plain text.
  3. Inspect a "Join the conversation" or "Be the first to comment" link in the browser's accessibility tree. Its name ends with the post title.
  4. Open "Template: Comments". Comment dates are plain text, and a commenter's avatar opens their site in the same tab.
  5. In the Site Editor, open Index and Single Posts. There are no block recovery warnings.

Checked on the front end, in the Site Editor, and with the Blue Hour and Evening variations.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: The accessibility audit, rebasing #93 onto trunk, the follow-up changes and this description.

🤖 Generated with Claude Code

noruzzamans and others added 2 commits October 8, 2026 11:40
…dding screen reader text to comments CTA

Cherry-picked from #93 (ea1bd81) onto trunk. The conflict in archive-columns.php, where trunk no longer wraps the date in a group, is resolved by keeping trunk's markup and dropping the date link.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Unlink the post dates in archive-lead and page-blog-home, which landed after #93.
- Unlink comment dates. The block links them by default, so comments from the same day shared a link name.
- Keep the comment avatar in the same tab. Its new-tab warning was only in an aria-label, so sighted visitors got none.
- Strip tags from the post title in the comments CTA's screen reader text, so titles with markup aren't read with their tags.

Part of #44.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added [Area] Patterns Issues or PRs that touch the theme's block patterns. [Area] Theme Functions Issues or PRs that touch functions.php. labels Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Patterns Issues or PRs that touch the theme's block patterns. [Area] Theme Functions Issues or PRs that touch functions.php.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ambiguous link texts found

2 participants