Update wp-coding-standards/wpcs to 3.4.1 - #756
Merged
Merged
Conversation
Bumps the constraint from 2.* to ^3.4.1 and regenerates composer.lock. Renames the ValidVariableName sniff property customPropertiesWhitelist to allowed_custom_properties, per the WPCS 3.0 property renames. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- phpcbf formatting fixes across plugins and theme. - PSR-12 file header fixes: import order (classes, then functions, then constants), blank lines after namespace declarations, and file docblocks where the first section comment was being treated as a misplaced file header. - Disable Universal.Operators.DisallowShortTernary in the ruleset; expanding short ternaries is a style call left to maintainers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates off the WPCS 2.x pin:
2.*to^3.4.1and regeneratescomposer.lock.WordPress.NamingConventions.ValidVariableNamepropertycustomPropertiesWhitelisttoallowed_custom_propertiesinphpcs.xml.dist— required by WPCS 3.0's property renames; with the old name, phpcs 3.x fails to run at all.For reference, a full-repo
phpcsscan under 3.4.1 reports 235 errors (213 auto-fixable) — mostly pre-existing and untouched here; CI lints changed files only.Part of an org-wide sweep to get all repos onto WPCS 3.4.1.
🤖 Generated with Claude Code