Streaming readers: Bytes, Filesystem, Zip #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
force-pushed
the
byte-readers
branch
from
966e692 to
b52a93c
Compare
adamziel
changed the title
This was referenced Dec 17, 2024
zaerl
pushed a commit
to WordPress/wordpress-playground
that referenced
this pull request
Jan 8, 2025
Sets the stage for the EPub importer. A part of #2080 Refactors and clean up the Data Liberation package. This includes renaming, reorganizing file paths, improving class structure, and removing deprecated/unused code. ## Key Changes **Refactor:** - Renamed `WP_WXR_Reader` to `WP_WXR_Entity_Reader` for consistency and clarity. - Adjusted references in related classes, tests, and imports. - Moved `byte-readers` to the Blueprints library (see WordPress/php-toolkit#121) **Cleanup:** - Deleted unused and redundant byte reader classes (`WP_Byte_Reader`, `WP_File_Reader`, etc.). - Removed legacy files such as `WXR_Import_Info`. **New Additions:** - Added `WP_Directory_Tree_Entity_Reader` to improve handling of directory tree imports. - Introduced `WP_Import_HTML_Processor` for better HTML import functionality. ## Testing instructions Confirm the CI tests passed
topdev22
added a commit
to topdev22/library
that referenced
this pull request
Feb 7, 2025
Adds streaming readers for: * Byte sources – both local and remote (with `seek()` support via range requests) * Zip – rewrites the original one to pull data from `WP_Byte_Source` as needed. * Filesystems – local FS, ZIP FS, a generic interface to add support for git and others This work is a pre-requisite for WordPress/php-toolkit#121 and will likely evolve. ## Testing instructions None. We'll need a good test coverage for all these primitives, but the work is still highly exploratory and meant to inform a larger refactorization of the step handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds streaming readers for:
seek()support via range requests)WP_Byte_Sourceas needed.This work is a pre-requisite for #121 and will likely evolve.
Testing instructions
None.
We'll need a good test coverage for all these primitives, but the work is still highly exploratory and meant to inform a larger refactorization of the step handlers.