Fix ambiguous column name error in ORDER BY clauses for JOIN queries

[Copilot]

This PR resolves an incompatibility between MySQL and SQLite when handling unqualified column names in ORDER BY clauses within JOIN queries.

Problem

SQLite treats ambiguous column names in ORDER BY clauses more strictly than MySQL. When a SELECT clause uses a fully qualified column reference but ORDER BY uses an unqualified reference to the same column, MySQL correctly infers the qualification while SQLite throws an "ambiguous column name" error.

For example, these queries work in MySQL but fail in SQLite:

-- Works in MySQL, fails in SQLite
SELECT t1.name FROM t1 JOIN t2 ON t2.t1_id = t1.id ORDER BY name;

-- Works in MySQL, fails in SQLite  
SELECT t2.name FROM t1 JOIN t2 ON t2.t1_id = t1.id ORDER BY name;

Solution

The fix adds intelligent column qualification resolution at the queryExpression level in the AST translator. When an ORDER BY clause contains unqualified column references:

1. Extract qualifications from the SELECT list to build a mapping of unqualified → qualified column names
2. Resolve unambiguous cases where exactly one qualified column in SELECT matches the unqualified ORDER BY column
3. Preserve existing behavior for truly ambiguous cases and already-qualified ORDER BY columns

Implementation Details

• Added translate_query_expression_with_order_by_fix() method to handle ORDER BY qualification
• Created helper methods to extract and analyze column qualifications from SELECT lists
• Added logic to automatically qualify ORDER BY columns when unambiguous
• Maintains backward compatibility - all existing functionality continues to work

Test Results

The fix successfully resolves the target cases while preserving expected failures:

✅ Now Working:

SELECT t1.name FROM t1 JOIN t2 ON t2.t1_id = t1.id ORDER BY name;  -- Resolves to t1.name
SELECT t2.name FROM t1 JOIN t2 ON t2.t1_id = t1.id ORDER BY name;  -- Resolves to t2.name

✅ Still Fail (As Expected):

SELECT t1.name, t2.name FROM t1 JOIN t2 ON t2.t1_id = t1.id ORDER BY name;  -- Truly ambiguous
SELECT t1.id FROM t1 JOIN t2 ON t2.t1_id = t1.id ORDER BY name;            -- Column not in SELECT

✅ Edge Cases Handled:

• Multiple ORDER BY columns with mixed qualification
• ORDER BY with DESC/ASC
• Table aliases and full table name qualification
• Complex expressions and function calls
• UNION queries and subqueries

Fixes #228.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/PHPCSStandards/PHP_CodeSniffer/zipball/5b5e3821314f947dd040c70f7992a64eac89025c
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/WPw4p5 /usr/bin/composer install (http block)
• https://api.github.com/repos/phar-io/manifest/zipball/54750ef60c58e43759730615a392c31c80e23176
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/WPw4p5 /usr/bin/composer install (http block)
• https://api.github.com/repos/phar-io/version/zipball/4f7fd7836c6f332bb2933569e566a0d6c4cbed74
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/WPw4p5 /usr/bin/composer install (http block)
• https://api.github.com/repos/php-parallel-lint/PHP-Parallel-Lint/zipball/6db563514f27e19595a19f45a4bf757b6401194e
  • Triggering command: /usr/bin/php8.3 -n -c /tmp/WPw4p5 /usr/bin/composer install (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

@adamziel 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

[adamziel]

This isn't a very good fix