Repository navigation
Toolbar: Add a "Skip toolbar" link when the toolbar precedes the page content - #14410
Closed
R1shabh-Gupta wants to merge 4 commits into
Closed
R1shabh-Gupta wants to merge 4 commits into
R1shabh-Gupta wants to merge 4 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
R1shabh-Gupta
marked this pull request as ready for review
October 19, 2026 09:38
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
joedolson
previously requested changes
Oct 27, 2026
joedolson
left a comment
joedolson
left a comment
Contributor
There was a problem hiding this comment.
One minor change; but this is otherwise in good shape.
R1shabh-Gupta
force-pushed
the
fix/66331-add-skip-toolbar-link
branch
from
October 29, 2026 07:35
0959d7f to
d30c530
Compare
R1shabh-Gupta
force-pushed
the
fix/66331-add-skip-toolbar-link
branch
from
November 2, 2026 11:40
87e774a to
dce6b04
Compare
joedolson
approved these changes
Nov 6, 2026
joedolson
left a comment
joedolson
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I debated for quite a while over having a name for the target, but ultimately feel that omitting it is better.
wporg-sync
pushed a commit
that referenced
this pull request
Nov 6, 2026
When the admin bar is rendered in the footer, a link is added to skip to the toolbar. However, if it is rendered at `wp_body_open`, it injects significant repeated content at the beginning of the page with no bypass mechanism. Add a skip link that targets a point after the end of the admin bar when it is rendered during `wp_body_open`, allowing users to bypass the navigation, supporting WCAG 2.4.1: Bypass Blocks. Developed in #14410. Props travisjeans, rishabhwp, ravi patel, joedolson. Fixes #66331. git-svn-id: https://develop.svn.wordpress.org/trunk@65325 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Nov 6, 2026
When the admin bar is rendered in the footer, a link is added to skip to the toolbar. However, if it is rendered at `wp_body_open`, it injects significant repeated content at the beginning of the page with no bypass mechanism. Add a skip link that targets a point after the end of the admin bar when it is rendered during `wp_body_open`, allowing users to bypass the navigation, supporting WCAG 2.4.1: Bypass Blocks. Developed in WordPress/wordpress-develop#14410. Props travisjeans, rishabhwp, ravi patel, joedolson. Fixes #66331. Built from https://develop.svn.wordpress.org/trunk@65325 git-svn-id: http://core.svn.wordpress.org/trunk@64465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the toolbar is rendered on
wp_body_open, it is the first thing on the page, so keyboard users must tab through every toolbar item before reaching the content.This adds a "Skip toolbar" link as the first element of the toolbar, targeting an empty, focusable element (
tabindex="-1") appended after the toolbar items.wp_body_opensupport, which keep the existing "Skip to toolbar" link.Trac ticket: https://core.trac.wordpress.org/ticket/66331
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Code Review & Writing test cases
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.