Repository navigation
Toolbar: Restore the hover background on top-level items - #15466
R1shabh-Gupta wants to merge 3 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
|
This looks good to me. The core of it is the same as what @jasmussen suggested in #13622 (comment), and the additional coverage cases make sense to me. It does eliminate the usage of |
The Blue, Coffee, Ectoplasm, Midnight, Ocean, and Sunrise color schemes lost their hover states following [65208]. The removal of the background change was fine in schemes where other colors were changed on hover, but not all schemes contain these changes. Apply color change to the parent `li` on `:hover` so all schemes have a visible `:hover` state in the adminbar. Developed in #15466. Props fushar, joen, rishabhwp, joedolson. Fixes #66463. git-svn-id: https://develop.svn.wordpress.org/trunk@65324 602fd350-edb4-49c9-b593-d223f7449a82
The Blue, Coffee, Ectoplasm, Midnight, Ocean, and Sunrise color schemes lost their hover states following [65208]. The removal of the background change was fine in schemes where other colors were changed on hover, but not all schemes contain these changes. Apply color change to the parent `li` on `:hover` so all schemes have a visible `:hover` state in the adminbar. Developed in WordPress/wordpress-develop#15466. Props fushar, joen, rishabhwp, joedolson. Fixes #66463. Built from https://develop.svn.wordpress.org/trunk@65324 git-svn-id: http://core.svn.wordpress.org/trunk@64464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Hovering a top-level Toolbar item shows no visible change in the Blue, Coffee, Ectoplasm, Midnight, Ocean and Sunrise color schemes, because their hover text color is the same as the default text color.
This brings back the hover background, painted on the
liinstead of the link. The link keeps its rounded focus outline, and the background stays square and lines up with the submenu. The search item keeps its existing no-background hover.Trac ticket: https://core.trac.wordpress.org/ticket/66463
Testing
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Code Review
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.