Repository navigation
Conversation
desrosj
changed the title
concurrency groups instead of head_ref.concurrency groups instead of head_ref.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
…head_ref`. The current standard across all GitHub Actions workflows is to configure `concurrency` to use the `github.head_ref` value in the `group` name for a given PR. Because `head_ref` only includes the branch name, workflow runs can be inadvertantly cancelled when two PRs are open from different forks with identical branch names. This switches to using the `github.event.pull_request.number` instead of `github.head_ref` to ensure that runs are properly grouped only with runs from the same pull request. A similar change has been made to `props-bot.yml`, which can be triggered by an `issue_comment` event. In this case, the `github.event.issue.number` will be used. In the context of GitHub, `issues == pull_requests` for the data returned by a number of request types. Merges [65249] to the 6.3 branch. Props lancewillett. See #65845.
f96ddb2 to
a82f4f4
Compare
lancewillett
left a comment
lancewillett
left a comment
There was a problem hiding this comment.
Checked against the 6.3 branch at a82f4f4: all 6 workflows whose concurrency group used github.head_ref now use github.event.pull_request.number, matching r65249, with the comment line updated to match. No head_ref is left under .github/ and nothing else changed. CI: 24 passed, 14 skipped, 0 failed.
AI review · claude-opus-5-5
Backports r65249 to the
6.3branch.Switches GitHub Actions
concurrencygroups fromgithub.head_ref(branch name only) togithub.event.pull_request.number, so workflow runs from PRs opened from different forks with identical branch names no longer cancel each other.props-bot.ymlusesgithub.event.pull_request.number || github.event.issue.numberto also coverissue_commentevents.All files in this branch that use
head_refin aconcurrencygroup were updated. Some of them (such ascheck-built-files.yml) do not exist intrunk.Trac ticket: https://core.trac.wordpress.org/ticket/65845
Use of AI Tools
Claude Code (Claude Opus 5.5) applied the trunk change to each branch with scripted substitutions and opened this PR. Each diff was checked to contain only the expected concurrency group and comment changes.
🤖 Generated with Claude Code