-
Notifications
You must be signed in to change notification settings - Fork 1
Add IGSN support #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add IGSN support #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for IGSN functionality by introducing new deposition models, collections, REST endpoints, and tests. Key changes include:
- Introducing DepositionModel, DepositionCollection, and PrefixCounter for handling IGSN operations.
- Updating navigation and REST route registrations to accommodate the new IGSN features.
- Extending settings and adding test suites to validate IGSN behavior.
Reviewed Changes
Copilot reviewed 47 out of 51 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| girder_jsonforms/web_client/models/index.js | Exporting the new DepositionModel. |
| girder_jsonforms/web_client/models/DepositionModel.js | New model for handling deposition metadata and IGSN logic. |
| girder_jsonforms/web_client/main.js | Added new navigation items for IGSN forms. |
| girder_jsonforms/web_client/collections/index.js | Exporting DepositionCollection along with other collections. |
| girder_jsonforms/web_client/collections/DepositionCollection.js | New collection for depositions with IGSN-specific sorting. |
| girder_jsonforms/tests/* | New tests for deposition flows and prefix counter behavior. |
| girder_jsonforms/settings.py | New IGSN-related settings and validators. |
| girder_jsonforms/rest/* | New REST endpoints and adjustments to support IGSN depositions. |
| girder_jsonforms/models/* | Updates to form and entry models for IGSN integration. |
| girder_jsonforms/lib/project_helpers.py | Helper functions for generating deposition indices. |
| girder_jsonforms/init.py | Updated plugin registration to include IGSN models and REST. |
Files not reviewed (4)
- girder_jsonforms/tests/data/gun_schema.json: Language not supported
- girder_jsonforms/tests/data/power_supply_schema.json: Language not supported
- girder_jsonforms/tests/data/target_schema.json: Language not supported
- girder_jsonforms/tests/data/target_source_schema.json: Language not supported
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
===========================================
+ Coverage 47.39% 63.38% +15.99%
===========================================
Files 10 19 +9
Lines 690 1841 +1151
===========================================
+ Hits 327 1167 +840
- Misses 363 674 +311 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tba