Skip to content

Conversation

@Xarthisius
Copy link
Owner

tba

@Xarthisius Xarthisius requested a review from Copilot April 2, 2025 23:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for IGSN functionality by introducing new deposition models, collections, REST endpoints, and tests. Key changes include:

  • Introducing DepositionModel, DepositionCollection, and PrefixCounter for handling IGSN operations.
  • Updating navigation and REST route registrations to accommodate the new IGSN features.
  • Extending settings and adding test suites to validate IGSN behavior.

Reviewed Changes

Copilot reviewed 47 out of 51 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
girder_jsonforms/web_client/models/index.js Exporting the new DepositionModel.
girder_jsonforms/web_client/models/DepositionModel.js New model for handling deposition metadata and IGSN logic.
girder_jsonforms/web_client/main.js Added new navigation items for IGSN forms.
girder_jsonforms/web_client/collections/index.js Exporting DepositionCollection along with other collections.
girder_jsonforms/web_client/collections/DepositionCollection.js New collection for depositions with IGSN-specific sorting.
girder_jsonforms/tests/* New tests for deposition flows and prefix counter behavior.
girder_jsonforms/settings.py New IGSN-related settings and validators.
girder_jsonforms/rest/* New REST endpoints and adjustments to support IGSN depositions.
girder_jsonforms/models/* Updates to form and entry models for IGSN integration.
girder_jsonforms/lib/project_helpers.py Helper functions for generating deposition indices.
girder_jsonforms/init.py Updated plugin registration to include IGSN models and REST.
Files not reviewed (4)
  • girder_jsonforms/tests/data/gun_schema.json: Language not supported
  • girder_jsonforms/tests/data/power_supply_schema.json: Language not supported
  • girder_jsonforms/tests/data/target_schema.json: Language not supported
  • girder_jsonforms/tests/data/target_source_schema.json: Language not supported

@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

❌ Patch coverage is 62.41245% with 483 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.38%. Comparing base (f5ddae7) to head (4afeb72).

Files with missing lines Patch % Lines
girder_jsonforms/worker_plugin/amdee.py 26.89% 87 Missing ⚠️
girder_jsonforms/__init__.py 39.83% 74 Missing ⚠️
girder_jsonforms/models/entry.py 54.13% 61 Missing ⚠️
girder_jsonforms/models/deposition.py 83.48% 53 Missing ⚠️
girder_jsonforms/lib/project_helpers.py 25.00% 51 Missing ⚠️
...irder_jsonforms/worker_plugin/handle_enumsource.py 50.00% 20 Missing ⚠️
girder_jsonforms/models/form.py 74.28% 18 Missing ⚠️
girder_jsonforms/rest/deposition.py 87.50% 18 Missing ⚠️
girder_jsonforms/settings.py 74.28% 18 Missing ⚠️
girder_jsonforms/worker_plugin/htmax.py 30.76% 18 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #20       +/-   ##
===========================================
+ Coverage   47.39%   63.38%   +15.99%     
===========================================
  Files          10       19        +9     
  Lines         690     1841     +1151     
===========================================
+ Hits          327     1167      +840     
- Misses        363      674      +311     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants