-
Notifications
You must be signed in to change notification settings - Fork 1
[Feat] 제보 완료화면 ViewModel 추가 #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
abe4b88
feat: 제보완료 VC 뷰 모델 추가
taipaise 885a272
Feat: 제보하기 로직 구현, 제보 히스토리 로직 구현 (#T3-204)
taipaise 549716a
feat: 제보완료 VC 뷰 모델 추가
taipaise 7a4721e
Fix: UI 일부 레이아웃 수정 및 서버 Enum 값 수정
choijungp a25dd6f
Fix: ReportCompleteViewController 충돌 해결
choijungp 79e42b6
Fix: PhotoURL 딕셔너리 제거
choijungp 2592b29
Fix: Report UI Date 형식 수정
choijungp 86493ac
Feat: 추천 루틴 탭 플로팅 버튼에 '제보하기' 진입점 추가
choijungp d3f482e
Feat: ReportRegistrationViewController 키보드 내려가기 및 이미지 선택 일부 수정
choijungp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configureAttribute/configureLayout가 두 번 호출될 가능성이 있습니다.BaseViewController의viewDidLoad()에서 이미configureAttribute(),configureLayout(),bind()를 호출하는 패턴이라면, Line 84–85에서 직접 다시 호출하면서 서브뷰 중복 추가·제약 중복 설정이 발생할 수 있습니다. 실제로 레이아웃 쪽은 두 번 도는 순간 Auto Layout 경고나 예기치 않은 뷰 계층 구조가 생길 수 있습니다.이 컨트롤러도
ReportDetailViewController와 동일하게super.viewDidLoad()이후에는 액션만 호출하도록 정리하는 편이 안전해 보입니다.override func viewDidLoad() { super.viewDidLoad() - configureAttribute() - configureLayout() viewModel.action(input: .fetchReportDetail(reportId: reportId)) }🤖 Prompt for AI Agents