Conversation
Address three Makefile review points: - Add a self-documenting `help` target (## comments + awk) and set it as `.DEFAULT_GOAL`, so a bare `make` no longer starts a `build-pine` Docker build unexpectedly. - Collapse `build-pine`/`build-bamboo`/`build-plum` into a single `build-%` pattern rule, which also adds the previously missing `build-palm` (the palm variant already exists in docker/ and the CI matrix) and removes the class of "forgot to add a variant target" bugs. These build targets are intentionally not `.PHONY`: GNU Make skips pattern rules for phony targets. - Generate the rubocop binstub with `bundle binstubs rubocop` so the `mitamae/bin/rubocop` file target is actually created; previously `bundle install` alone never satisfied it, re-running on every lint/format. Exclude the generated `bin/` directory from RuboCop so it no longer lints its own binstub. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VhbGtHikMteSTrg9seCWsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses three review points on the root
Makefile:make help+ safe default goal — a self-documentinghelptarget (##comments + awk) is now.DEFAULT_GOAL. Previously a baremakefired the first target (build-pine), kicking off a Docker build unexpectedly.build-%pattern rule (adds missingbuild-palm) — the three explicitbuild-pine/build-bamboo/build-plumrecipes collapse into onebuild-%rule. This restores parity with the CI build matrix anddocker/Dockerfile.palm(which had no Make target) and removes the "forgot to add a variant target" failure mode entirely. These build targets are intentionally not.PHONY: GNU Make skips pattern rules for phony targets (a phonybuild-palmyieldsNothing to be done).build-%andbuild-lxc-%coexist safely via shortest-stem matching.mitamae/bin/rubocoprecipe now runsbundle binstubs rubocop, so the file target is actually created andbundle installstops re-running on everymake lint/make format. The generatedbin/directory is excluded from RuboCop so it no longer lints its own binstub.Type of Change
Makefile) and RuboCop configPlatforms Tested
Checklist
bundle exec rubocoppasses (verified viamake lint: 107 files, no offenses)make lintskipsbundle install(file target satisfied) and runs the binstub directlyonly_if/not_if) are in place where needed — N/AVerification
make/make help→ prints the target listing, no Docker buildmake -n build-palm→docker build -t yuseiito-dev:palm -f docker/Dockerfile.palm .make -n build-lxc-pine→sudo scripts/build-lxc.sh pine(collision-safe)make lintrun twice → binstub created on first run,bundle installskipped on second; RuboCop reports no offenses🤖 Generated with Claude Code
Generated by Claude Code