Go bindings: extract CGo slice-conversion helpers to eliminate boilerplate#9465
Merged
NikolajBjorner merged 2 commits intoMay 6, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/Z3Prover/z3/sessions/eb6e05d8-f45a-40fb-b61f-17d4058bccb6 Co-authored-by: NikolajBjorner <3085284+NikolajBjorner@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Simplify Go bindings by extracting CGo slice conversion helpers
Go bindings: extract CGo slice-conversion helpers to eliminate boilerplate
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces repetitive CGo slice-conversion patterns in
src/api/go/z3.goby extracting three package-internal helpers, eliminating 13 instances of 4–9 line repeated blocks.Helpers added
Each returns the backing slice (to keep it alive across the CGo boundary) and a nil-safe pointer to the first element.
Before / After
Other simplification
Replaced verbose 5-line
if/elseC.boolassignments inMkQuantifierandMkQuantifierConstwith the direct cast already used elsewhere in the bindings:Net: −66 lines. No functional changes.