feat: add minimum hearts threshold for heart item spawning#80
Open
Scralar wants to merge 1 commit intoZetaPlugins:mainfrom
Open
feat: add minimum hearts threshold for heart item spawning#80Scralar wants to merge 1 commit intoZetaPlugins:mainfrom
Scralar wants to merge 1 commit intoZetaPlugins:mainfrom
Conversation
- Add minHeartsToSpawnHeartItem config option to control when players can drop/give hearts - Players below threshold still lose hearts but won't spawn heart items - Add heartSpawningBlocked property to death events for plugin integration - Apply threshold to all heart dropping mechanisms (PvP, natural, cooldown, max hearts) - Update README and config documentation - Default value is 0 (disabled) to maintain backward compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Added a minimum hearts threshold system that prevents players from dropping or giving heart items when they die if they have below a certain number of hearts. Players still lose hearts from their max health, but no heart items are spawned.
New stuff
minHeartsToSpawnHeartItem- controls minimum hearts required to spawn heart itemsheartSpawningBlockedin death events for plugin integrationHow it works
When a player dies with hearts below the threshold:
Files changed
minHeartsToSpawnHeartItemconfig option with documentationcanSpawnHeartItem()utility method in PlayerDeathListenerhandlePvPDeath()andhandleNaturalDeath()to check thresholdheartSpawningBlockedproperty to death eventsTesting
Built and compiled fine, follows existing code patterns. All heart dropping mechanisms now respect the threshold.
Notes