Add config option to prevent heart drops at minimum heart count#84
Open
NAMERIO wants to merge 1 commit into
Open
Add config option to prevent heart drops at minimum heart count#84NAMERIO wants to merge 1 commit into
NAMERIO wants to merge 1 commit into
Conversation
Member
|
Why not just use the |
Author
|
heartRewardOnElimination is only about giving the killer extra hearts when they eliminate someone. It does not stop a player at minimum hearts from dropping a heart when they die to fall damage or mobs. |
Member
|
Alright then. I'll review it after Christmas! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration option noDropAfterMinHeart. When enabled, if the minimum heart is set to 1 (so players don’t get banned), it prevents players from farming hearts by dying at 1 heart and dropping a heart each time.