Skip to content

feat: add ranges for attribute node values#1383

Merged
a-h merged 2 commits into
a-h:mainfrom
AdamVig:attribute-value-range
May 10, 2026
Merged

feat: add ranges for attribute node values#1383
a-h merged 2 commits into
a-h:mainfrom
AdamVig:attribute-value-range

Conversation

@AdamVig
Copy link
Copy Markdown
Contributor

@AdamVig AdamVig commented May 7, 2026

Adds a ValueRange to ConstantAttribute. In href="test", it covers test.
Adds an InitializerRange to ExpressionAttribute. In href={ user.URL } it covers ={ user.URL } (ExpressionAttribute.Expression.Range already covers user.URL).

Continues the initiative of adding Range to all AST nodes for the benefit of external linting tools, which started in #1225 and was originally discussed in #586.

See also #1301, #1302, #1335, #1336, #1337, #1338, #1340, #1341, #1347, #1348, and #1350.

@a-h a-h merged commit ff38cee into a-h:main May 10, 2026
4 checks passed
@AdamVig AdamVig deleted the attribute-value-range branch May 20, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants