Skip to content

cmd/templ/lspcmd/proxy: set 'templ' as client name in initialize client info#966

Open
hyangah wants to merge 2 commits intoa-h:mainfrom
hyangah:main
Open

cmd/templ/lspcmd/proxy: set 'templ' as client name in initialize client info#966
hyangah wants to merge 2 commits intoa-h:mainfrom
hyangah:main

Conversation

@hyangah
Copy link
Copy Markdown

@hyangah hyangah commented Oct 24, 2024

This allows gopls to recognize gopls instances serving for templ and count separately in go telemetry data processing.

@a-h
Copy link
Copy Markdown
Owner

a-h commented Oct 25, 2024

Ah, good idea! I'm not familiar with the format of adding a ; followed by the name, is that common practice?

Do you any links to the telemetry dataset etc. or conversations about that?

The reason I ask is that once it's set, it's probably hard to change, since it would affect historic data collection, so I just want to cover that before merging.

I'd like to see telemetry of the templ LSP. For example, it may be possible to see new issues early using the telemetry.

This allows gopls to recognize gopls instances serving for templ
and count separately in go telemetry data processing.
@hyangah hyangah changed the title cmd/templ/lspcmd/proxy: append ';templ' in initialize client info cmd/templ/lspcmd/proxy: set 'templ' as client name in initialize client info Nov 19, 2024
@hyangah
Copy link
Copy Markdown
Author

hyangah commented Nov 19, 2024

Hi @a-h
golang/go#70205 is the upstream issue. After the discussion, we think just setting "templ" instead of appending it is the right approach. Updated the PR.

@a-h
Copy link
Copy Markdown
Owner

a-h commented Nov 19, 2024

Thanks! I'll probably be able to look at this the day after tomorrow.

@a-h
Copy link
Copy Markdown
Owner

a-h commented Dec 27, 2024

@hyangah what's the status on this now then? I think we're still waiting on the discussion in golang/go#70205 to resolve. I've added a comment there to explain how templ works etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants