Optional permissions#15
Merged
Merged
Conversation
Owner
Author
|
This new system isn't working on Firefox Android and I'm having some trouble getting the extension to show up at all in a debug session. |
Owner
Author
|
All the functionality is in now, via an options page. Remaining work is to improve the UX for a non-developer user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #4
The extension will now only require the
tabspermission up front. Users opt-in to every other site-based permission by manually approving it through the extension icon.This makes it possible to add more and more sites to the extension without requiring existing users to re-approve the entire extension.
It's also in the user's best interest to have full control over what sites the extension can interact with.
The last benefit is that the extension no longer uses
browser.contentScriptswhich isn't supported in Chrome and probably will never be. This was a problem discovered in #10. So we are one step closer to making the extension cross-browser.