fix: Fix historyLength filtering semantics#432
Merged
bartek-gralewicz merged 11 commits intoApr 30, 2026
Merged
Conversation
🧪 Code Coverage
Generated by coverage-comment.yml |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the DefaultRequestHandler to implement historyLength semantics per specification §3.2.4, allowing for full history retrieval when the parameter is undefined and empty history when it is zero or less. Corresponding unit tests have been added to cover these scenarios. The reviewer suggested creating a helper function in the test file to reduce code duplication when initializing task objects.
…bgralewicz/fix_history_length_semantics
ishymko
reviewed
Apr 28, 2026
…bgralewicz/fix_history_length_semantics
…d message methods as well as listTasks.
…th historyLength semantics.
…quest handler. Added test cases for listTasks with history semantics.
ishymko
reviewed
Apr 29, 2026
ishymko
approved these changes
Apr 30, 2026
…bgralewicz/fix_history_length_semantics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug in
historyLengthfiltering semantics. The behavior for undefinedhistoryLengthand equal to 0 were reversed.Before
historyLengthundefined => no historyhistoryLength = 0=> all historyhistoryLength = N=> at most N most recent messages returnedAfter (spec aligned)
historyLengthundefined => all historyhistoryLength = 0=> no historyhistoryLength = N=> at most N most recent messages returned