Refactor/actions reserve overview by AGMASO · Pull Request #2799 · aave/interface

AGMASO · 2025-12-04T16:12:59Z

General Changes

• Refactored the Supply and Borrow actions on the reserve-overview page to fully use the SDK for calculating health factor previews and for building the transaction to be sent.
• Special cases for wrapped tokens (DAI/sDAI) and USDT resets are all covered and tested.

• This PR also includes the refactor of Withdraw and Repay (added here for future use in the dashboard page).

Developer Notes

• For testing purposes, you can access the Supply SDK and Borrow SDK in the reserve-overview page.
• You can access the Withdraw SDK and Repay SDK in the supplied position view and borrowed position view respectively.

• NOTE: Major issue blocking the release of the Repay SDK flow: I have tested that the SDK’s Repay action does not support aToken repayments. This means we cannot repay debt using collateral; only ERC-20 tokens from the wallet are supported.

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

End-to-end tests are passing without any errors
Code changes do not significantly increase the application bundle size
If there are new 3rd-party packages, they do not introduce potential security threats
If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

… sdk

…-page-sdk

…factor/reserve-overview-page-sdk

…sing action

github-actions · 2025-12-08T14:02:08Z

Ipfs hash: bafybeiavucemropkhhqb7mdpijqvsyurfsm6vvbup3gudckezrsbe34fsu
Ipfs preview link: https://bafybeiavucemropkhhqb7mdpijqvsyurfsm6vvbup3gudckezrsbe34fsu.ipfs.cf-ipfs.com/

github-actions · 2025-12-08T14:02:33Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-09T20:05:45Z

Ipfs hash: bafybeihfz5q5towarjzg62oqavtv2ilcrz7uhd55g4lscwyutfzkadns4a
Ipfs preview link: https://bafybeihfz5q5towarjzg62oqavtv2ilcrz7uhd55g4lscwyutfzkadns4a.ipfs.cf-ipfs.com/

github-actions · 2025-12-09T20:05:51Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mgrabina

HUGE work! Adding some comments.

Idea for relase: prepare a dashboard on amplitude to track all actions and quickly monitor in case we have any issues.

src/hooks/useWrappedTokens.tsx

mgrabina · 2025-12-09T20:56:55Z

src/modules/reserve-overview/ReserveActions.tsx

-    ).toString();
+  if (reserve.userState) {
+    maxAmountToBorrow = reserve.userState.borrowable.amount.value || '0';
+    maxAmountToSupply = getMaxAmountAvailableToSupplySDK(walletBalance, reserve, underlyingAsset);


aren't we losing minRemainingBaseTokenBalance condition?

During debugging, I noticed an inconsistency between the Legacy flow and the SDK. The difference in the amounts was exactly the value I was using for minRemainingBaseTokenBalance. For that reason, I simplified it. I have the feeling that the SDK already includes minRemainingBaseTokenBalance in its backend calculations. not 100% sure, but is working identical like that

makes sense

mgrabina · 2025-12-09T20:59:29Z

src/modules/reserve-overview/ReserveActions.tsx

-    balance = walletBalances[API_ETH_MOCK_ADDRESS.toLowerCase()];
-  }
-
+  const isNativeSelected = reserve.acceptsNative && selectedAsset === baseAssetSymbol;


should we use isWrappedBaseAsset condition instead of acceptsNative? not sure

same question everywhere in this file

isWrappedBaseAsset is a flag from API legacy, not present in SDK. The equivalent would be that the object reserve.acceptsNative is not null.

src/components/transactions/Repay/RepayModalContentSDK.tsx

mgrabina · 2025-12-09T21:18:42Z

src/components/transactions/Supply/SupplyModalContentSDK.tsx

+            visibleDecimals={2}
+          />
+          <Typography variant="subheader2" color="text.secondary">
+            sDAI


Is this hardcoded symbol intended?

yeah. same as the Legacy Flow

mgrabina · 2025-12-09T21:19:56Z

src/components/transactions/Supply/SupplyModalContentSDK.tsx

+          tokenWrapperAddress={wrappedTokenConfig.tokenWrapperAddress}
+          tokenIn={wrappedTokenConfig.tokenIn.underlyingAsset}
+          amountToSupply={amount}
+          decimals={18}


18 decimals hardcoded intended?

yeah, required for the case sDai (i just followed the legacy flow)

mgrabina · 2025-12-09T21:22:52Z

src/components/transactions/Supply/SupplyActionsSDK.tsx

+      <TxActionsWrapper
+        blocked={blocked}
+        mainTxState={mainTxState}
+        approvalTxState={{}}


we are probably losing the approval state in the button here

We’re using the useApprovalTx hook, which handles all approval state and execution internally, so we no longer need to pass approvalTxState to the wrapper. Tested and it works fine.

Yeah but that wrapper isn't chaing the text based on the approvalTxState?

ok, make sense. updated

mgrabina · 2025-12-09T21:47:12Z

src/components/transactions/Supply/SupplyModalContentSDK.tsx

+          reserve={poolReserve}
+        />
+      ) : (
+        <SupplyActions


or SDK? let's add some comments explaining why we need different Actions for Wrapped or when we use each one for future reference

Same for other actions

sorry! you are right, for the fallback should be SupplyActionsSDK as well

comments added

github-actions · 2025-12-10T11:11:01Z

Ipfs hash: bafybeidzsilqpmekh62gv2hbyk6gpbckdm5jaradqkdm2sjdyds2rddwhm
Ipfs preview link: https://bafybeidzsilqpmekh62gv2hbyk6gpbckdm5jaradqkdm2sjdyds2rddwhm.ipfs.cf-ipfs.com/

github-actions · 2025-12-10T11:11:13Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-10T12:34:07Z

Ipfs hash: bafybeifakanatdkhk45dtgmllzuhaizuuirc5jlqchtuctluaxv2ibcume
Ipfs preview link: https://bafybeifakanatdkhk45dtgmllzuhaizuuirc5jlqchtuctluaxv2ibcume.ipfs.cf-ipfs.com/

github-actions · 2025-12-10T12:34:22Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

vercel · 2025-12-11T09:56:53Z

You must have Developer access to commit code to Aave on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

github-actions · 2025-12-11T10:03:12Z

Ipfs hash: bafybeiegguykvt62juekfca5cilh2p4t66t2myxmwf2xhegqbmf2oocuuy
Ipfs preview link: https://bafybeiegguykvt62juekfca5cilh2p4t66t2myxmwf2xhegqbmf2oocuuy.ipfs.cf-ipfs.com/

github-actions · 2025-12-11T10:03:18Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

AGMASO added 30 commits September 26, 2025 16:05

refactor: sdk integrated in market page

114328f

chore: clean code

940cdf4

fix: simplified icon fetch logic & clean code

fcb1a39

fix: build error

92eeffd

fix: build error

a80c04b

fix: build error

4a5e1fe

chore: clean code

eff6ed6

chore: clean code

8653eb9

refactor: integrate sdk into reserve-overview. missing few flags from…

75769d3

… sdk

fix: show disabled only for > 0 amounts

be28f80

Merge branch 'refactor/sdk-in-markets' into refactor/reserve-overview…

c4d503f

…-page-sdk

fix: solved issue on tokenIcons in reserve-overview page

9f5d624

fix: clean code

47ec420

fix: clean code

18dadae

fix: clean code

27eb9b8

chore: clean code

8f7da60

feat: added interest Rate Strategy Address to link, after updated sdk

2e502e9

fix: use typescript guards

d3d3e45

fix: simplified code

3610842

refactor: move incentives calculation to parent component

4e83b97

chore: clean code

de6b877

Merge branch 'refactor/sdk-in-markets' into refactor/reserve-overview…

cdc1ae9

…-page-sdk

feat: added Pts-ethena tokens to mapping

f8fa340

chore: trigger rebuild

5b6f0ee

Merge remote-tracking branch 'origin/refactor/sdk-in-markets' into re…

ca6db43

…factor/reserve-overview-page-sdk

chore: bump aave-sdk versions

21ca830

fix: isolationdebtceiling values displaying correct now

d31da54

Merge branch 'main' into refactor/reserve-overview-page-sdk

2ea35f5

fix: build error

16ed69e

feat: refactoring in progress, being supply refactored using sdk, mis…

764c8d5

…sing action

AGMASO requested review from JoaquinBattilana and grothem December 4, 2025 17:27

Merge branch 'main' into refactor/actions-reserve-overview

a0d2d38

vercel bot deployed to Preview December 8, 2025 13:59 View deployment

AGMASO added 2 commits December 9, 2025 20:58

feat: refactored withdraw and repay flows with sdk v3

cd6efe0

Merge branch 'main' into refactor/actions-reserve-overview

94ad96d

vercel bot deployed to Preview December 9, 2025 20:04 View deployment

mgrabina reviewed Dec 9, 2025

View reviewed changes

fix: debugging flows and clean code

027f2b8

vercel bot deployed to Preview December 10, 2025 11:01 View deployment

chore: clean code

12eb28b

vercel bot deployed to Preview December 10, 2025 11:06 View deployment

fix: max amount to withdraw now respect the hf

6400f6e

vercel bot deployed to Preview December 10, 2025 12:30 View deployment

fix: fallback needs to be sdk action

932414d

vercel bot deployed to Preview December 10, 2025 12:44 View deployment

AGMASO requested a review from mgrabina December 10, 2025 12:59

fix: approvalTxState with param

d57a6b9

Conversation

AGMASO commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

General Changes

Developer Notes

Reviewer Checklist

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

github-actions bot commented Dec 8, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

mgrabina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

github-actions bot commented Dec 10, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

github-actions bot commented Dec 10, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

vercel bot commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

Reviewers

Assignees

Labels

Projects

AGMASO commented Dec 4, 2025 •

edited

Loading