Add progress bar background to wireplumber items - #736
Open
kontura wants to merge 3 commits into
Open
Conversation
Using custom PercentageLayoutManager seems to be the only viable approach that allows drawing the progress bar in the background while it still being fully stylable by css. I have tried using GtkProgressBar but it is hard to ensure it fully stretches in the backround. Using GtkDrawingArea is not really stylable by css. Using only a GtkBox is also not possible because it doesn't support setting width by percentage.
We are parsing the percentage from the subtext but perhaps it would be better to pass it separately from elephant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly it could also be used for Bluetooth items to indicate battery level.