Conversation
|
For now "usual" CI run to ensure that nothing will change / break |
andrewprzh
left a comment
There was a problem hiding this comment.
Looks good to me.
-
Word "frugal" is cool but not so common, any synonyms? (just for the sake of non-native speakers)
-
I checked calls of EnsureBasicMapping across the project, seems to be correct, but just in case to double check:
./projects/online_vis/base_commands.hpp: EnsureBasicMapping(curr_env->graph_pack()); ./projects/hpcspades/mismatch_correction_mpi.hpp: EnsureBasicMapping(gp); ./projects/spades/restricted_edges_filling.cpp: EnsureBasicMapping(gp, !cfg::get().frugal); ./projects/spades/pair_info_count.cpp: EnsureBasicMapping(gp, !cfg::get().frugal); ./projects/spades/series_analysis.cpp:// gp.EnsureBasicMapping(); ./projects/spades/mismatch_correction.cpp: EnsureBasicMapping(gp); ./projects/spades/hybrid_aligning.cpp: EnsureBasicMapping(gp, !cfg::get().frugal); ./projects/cds_subgraphs/stats.cpp: EnsureBasicMapping(gp); ./projects/cds_subgraphs/cds_subgraphs.cpp: EnsureBasicMapping(gp); ./projects/cds_subgraphs/unitig_coverage.cpp: EnsureBasicMapping(gp); ./projects/cds_subgraphs/mag_improve.cpp: EnsureBasicMapping(gp); ./common/pipeline/graph_pack_helpers.cpp:void EnsureBasicMapping(GraphPack& gp, bool check_mapper) { ./common/pipeline/graph_pack_helpers.cpp: EnsureBasicMapping(gp); ./common/pipeline/graph_pack_helpers.h:void EnsureBasicMapping(graph_pack::GraphPack& gp, ./common/stages/ss_edge_split.cpp: EnsureBasicMapping(gp, !cfg::get().frugal); ./test/debruijn/test_utils.cpp: EnsureBasicMapping(gp); ./test/examples/thread_sequences.cpp: EnsureBasicMapping(gp);
Yeah, I checked all of them. Essentially mismatch corrector is entirely disabled as it uses kmer mapper in non-trivial way. Everything else just does sequence mapping and therefore can operate without kmer mapper. |
No description provided.