Skip to content

Conversation

@maratal
Copy link
Collaborator

@maratal maratal commented Nov 2, 2025

Closes #438

  • failedToResolveSubscriptionPointBecauseChannelSerialNotDefined: renamed since channelSerial checked first. Introduced error code used in JS - 102_110;
  • failedToResolveSubscriptionPointBecauseChannelFailedToAttach: changed error code to 102_112 (roomInInvalidState), JS doesn't throw anything and just waits for channel attach event. Proposed spec for throwing an error with 102_112 code;
  • noItemInResponse: changed error code to 404 and proposed spec for that;
  • failedToGetPaginatedResult: renamed and added full error info taken from realtime, JS also throws error with values from realtime. Am not sure what to do with badRequest here, probably it's fine to leave it (or internalServerError maybe?);
  • headersValueJSONDecodingError and jsonValueDecodingError are JSON parser errors and probably should stay with badRequest.

Removed unused MessagesError enum.

Proposed specs: ably/specification#401

@coderabbitai
Copy link

coderabbitai bot commented Nov 2, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 438-non-specified-errors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@maratal maratal changed the title Change non spec errors [ECO-5616] Change non spec errors Nov 2, 2025
@github-actions github-actions bot temporarily deployed to staging/pull/468/AblyChat November 2, 2025 22:01 Inactive
@maratal maratal force-pushed the 438-non-specified-errors branch from fd192a2 to 38fafd4 Compare November 2, 2025 22:25
@github-actions github-actions bot temporarily deployed to staging/pull/468/AblyChat November 2, 2025 22:26 Inactive
@maratal maratal force-pushed the 438-non-specified-errors branch from 38fafd4 to 1e40805 Compare November 2, 2025 23:05
@github-actions github-actions bot temporarily deployed to staging/pull/468/AblyChat November 2, 2025 23:07 Inactive
- failedToResolveSubscriptionPointBecauseChannelSerialNotDefined: renamed since `channelSerial` checked first. Introduced error code used in JS - 102_110;
- failedToResolveSubscriptionPointBecauseChannelFailedToAttach: changed error code to 102_112 (roomInInvalidState), JS doesn't throw anything and just waits for channel attach event. Proposed spec for throwing an error with 102_112 code;
- noItemInResponse: changed error code to 404 and proposed spec for that;
- failedToGetPaginatedResult: renamed and added full error info taken from realtime, JS also throws error with values from realtime. Am not sure what to do with `badRequest` here, probably it's fine to leave it (or `internalServerError` maybe?);
- headersValueJSONDecodingError and jsonValueDecodingError are JSON parser errors and probably should stay with `badRequest`.

Removed unused `MessagesError` enum.

Proposed specs: ably/specification#401
@maratal maratal force-pushed the 438-non-specified-errors branch from 1e40805 to 45958a0 Compare November 2, 2025 23:11
@github-actions github-actions bot temporarily deployed to staging/pull/468/AblyChat November 2, 2025 23:12 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/468/AblyChat November 7, 2025 17:10 Inactive
…iledToAttach` error, since M5b assumes waiting until ATTACHED. Also lines up with JS implementation.
@maratal maratal force-pushed the 438-non-specified-errors branch from f60a57c to 446576e Compare November 7, 2025 17:32
@github-actions github-actions bot temporarily deployed to staging/pull/468/AblyChat November 7, 2025 17:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Audit the non-specified errors that we throw

2 participants