-
Notifications
You must be signed in to change notification settings - Fork 18
docs: clarify release steps in CONTRIBUTING.md #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdates to CONTRIBUTING.md with formatting corrections, restructured release workflow steps, reordered tagging and publishing sequence, addition of workflow approval step for pub.dev publication, and changelog update requirement. Guidance added for replacing HEAD with version tags in autogenerated URLs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bfeb98d to
e2c6920
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CONTRIBUTING.md (1)
201-205: Clarify that pub.dev publishing is now automated via Release Workflow.The restructured release process (steps 10–14) removes the manual
flutter pub publishstep and introduces automated publishing through the Release Workflow (step 13). While this is a good practice, the documentation should explicitly state that pub.dev publication is now delegated to the CI/CD workflow rather than run manually. This will help maintainers understand the flow and avoid duplicate publication attempts.Consider adding a clarifying note before step 10, such as:
+After the release PR is landed: + 10. Create a tag named like `v1.2.3`, using `git tag v1.2.3`This makes it clear that the next phase shifts from PR approval to automated release tasks.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
CONTRIBUTING.md(2 hunks)
🧰 Additional context used
🪛 LanguageTool
CONTRIBUTING.md
[uncategorized] ~191-~191: The official name of this software platform is spelled with a capital “H”.
Context: ...ntegration/ios - Commit this 4. Run [github_changelog_generator`](https://github.co...
(GITHUB)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: android
- GitHub Check: ios
- GitHub Check: android (24)
- GitHub Check: ios
- GitHub Check: android (29)
🔇 Additional comments (1)
CONTRIBUTING.md (1)
191-195: Approve added guidance for URL replacement.The new instruction at line 195 to replace
HEADin autogenerated URLs with the actual version tag (e.g.,v1.2.3) is helpful and removes ambiguity. This clarification improves the release process documentation.
| 13. Create a release on GitHub following the [previous releases]((https://github.com/ably/ably-flutter/releases)) as examples. | ||
| 10. Create a tag named like `v1.2.3`, using `git tag v1.2.3` | ||
| 11. Push the newly created tag to GitHub: `git push origin v1.2.3` | ||
| 12. Create a release on GitHub following the [previous releases]((https://github.com/ably/ably-flutter/releases)) as examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix malformed markdown link syntax.
Line 203 (step 12) contains double opening parentheses in the link: ]((https://...)). This should be ](https://...).
-12. Create a release on GitHub following the [previous releases]((https://github.com/ably/ably-flutter/releases)) as examples.
+12. Create a release on GitHub following the [previous releases](https://github.com/ably/ably-flutter/releases) as examples.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 12. Create a release on GitHub following the [previous releases]((https://github.com/ably/ably-flutter/releases)) as examples. | |
| 12. Create a release on GitHub following the [previous releases](https://github.com/ably/ably-flutter/releases) as examples. |
🤖 Prompt for AI Agents
In CONTRIBUTING.md around line 203, the markdown link in step 12 uses malformed
syntax with double opening parentheses `]((https://...) )`; replace it with the
correct link syntax `](https://...)` so the link renders properly (remove the
extra parenthesis).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
Clarify release steps in CONTRIBUTING.md
Summary by CodeRabbit