Use DESCRIBES relationships instead of deprecated documentDescribes for SPDX 2.3+#2024
Closed
mr-raj12 wants to merge 1 commit intoaboutcode-org:mainfrom
Closed
Use DESCRIBES relationships instead of deprecated documentDescribes for SPDX 2.3+#2024mr-raj12 wants to merge 1 commit intoaboutcode-org:mainfrom
mr-raj12 wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
…or SPDX 2.3+ The documentDescribes field is deprecated in SPDX 2.3 specification. This change: - Uses DESCRIBES relationships for SPDX 2.3+ output - Maintains backward compatibility with documentDescribes for SPDX 2.2 - Handles both formats when parsing SPDX documents Fixes aboutcode-org#1958 Signed-off-by: Mrityunjay Raj <mr.raj.earth@gmail.com>
0893d32 to
dcd9c57
Compare
Author
|
Hi @tdruez! 👋 This PR updates the SPDX export to use the DESCRIBES relationship (new in SPDX 2.3+) instead of the deprecated documentDescribes. Would love to get your feedback when you have time. Thanks! |
Contributor
|
@mr-raj12 We do not plan to change the behavior of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1958
Test plan
test_spdx_document_2_3_uses_describes_relationshipstest_spdx_document_2_2_uses_document_describestest_spdx_document_from_data_with_describes_relationshipstest_spdx_document_from_data_with_document_describes