Skip to content

Fix for createSubscription w/ processingDirective #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2025
Merged

Fix for createSubscription w/ processingDirective #901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7d3cda
Added FulfillmentInventorybyMarketplace notification payload
nicopizzo Oct 25, 2025
72eac4b
Revert "Added FulfillmentInventorybyMarketplace notification payload"
nicopizzo Oct 26, 2025
cb8054a
Ignore null properties on event filter
nicopizzo Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Notifications/AggregationFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class AggregationFilter
/// Gets or Sets AggregationSettings
/// </summary>
[DataMember(Name = "aggregationSettings", EmitDefaultValue = false)]
[JsonProperty(PropertyName = "aggregationSettings")]
[JsonProperty(PropertyName = "aggregationSettings", NullValueHandling = NullValueHandling.Ignore)]
public AggregationSettings AggregationSettings { get; set; }


Expand Down
6 changes: 3 additions & 3 deletions Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Notifications/EventFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,22 @@ public class EventFilter : AggregationFilter
/// Gets or Sets MarketplaceIds
/// </summary>
[DataMember(Name = "marketplaceIds", EmitDefaultValue = false)]
[JsonProperty(PropertyName = "marketplaceIds")]
[JsonProperty(PropertyName = "marketplaceIds", NullValueHandling = NullValueHandling.Ignore)]
public IList<string> MarketplaceIds { get; set; }

/// <summary>
/// An eventFilterType value that is supported by the specific notificationType. This is used by the subscription service to determine the type of event filter. Refer to the section of the [Notifications Use Case Guide](doc:notifications-api-v1-use-case-guide) that describes the specific notificationType to determine if an eventFilterType is supported.
/// </summary>
/// <value>An eventFilterType value that is supported by the specific notificationType. This is used by the subscription service to determine the type of event filter. Refer to the section of the [Notifications Use Case Guide](doc:notifications-api-v1-use-case-guide) that describes the specific notificationType to determine if an eventFilterType is supported.</value>
[DataMember(Name = "eventFilterType", EmitDefaultValue = false)]
[JsonProperty(PropertyName = "eventFilterType")]
[JsonProperty(PropertyName = "eventFilterType", NullValueHandling = NullValueHandling.Ignore)]
public string EventFilterType { get; set; }

/// <summary>
/// Gets or Sets OrderChangeTypes
/// </summary>
[DataMember(Name = "orderChangeTypes", EmitDefaultValue = false)]
[JsonProperty(PropertyName = "orderChangeTypes")]
[JsonProperty(PropertyName = "orderChangeTypes", NullValueHandling = NullValueHandling.Ignore)]
public IList<string> OrderChangeTypes { get; set; }


Expand Down
Loading