Fix/creator dashboard notifications twitter share - #819
Merged
Chucks1093 merged 6 commits intoAug 29, 2026
Merged
Conversation
|
@Alaka-ibr Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Merge staking fields (stakingPoolBalance, totalStaked, recentFeeInflow, name, bio, avatarUri, auctionPrice, auctionSupply, auctionSold) and stakedQuantity on KeyHolderEntry from upstream/dev into course.service.ts - Keep co-creator fields and setCoCreator() method from this branch - Merge StakingRewardsSection from upstream/dev into CreatorDetailPage - Keep ShareTwitterButton, CoCreatorSection, and improved 404 handling from this branch in CreatorDetailPage
…d-notifications-twitter-share
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #811
Closes #800
Closes #797
Closes #812
Fixed Issues
Key Changes Made
1. Co-Creator Revenue Split Display & Config (#811)
Courseinterface incourse.service.tswithcoCreatorAddress,coCreatorSplitBps,totalPaidToCoCreator, andtotalPaidToCreator.setCoCreatormethod incourseService(POST /courses/:id/co-creator) anduseSetCoCreatormutation hook inuseCreators.ts.coCreator.utils.tsfor validating Stellar G-addresses (/^G[A-Z2-7]{55}$/) and basis point range (1–10000).SetCoCreatorModal.tsxdialog form with input validation and success toast notification upon save.CoCreatorSection.tsxdisplaying truncated address with copy button, split percentage, total paid stat cards, and'No co-creator configured'empty state.CoCreatorSectionintoCreatorDetailPage.tsx.2. Global Notification Drawer & Polling (#800)
'trade_completed','lockup_expiring', and'price_moved'notification types andmarkAllAsReadendpoint innotification.service.ts.useNotifications.tswith 60-second polling (refetchInterval: 60000) and optimisticmarkAllAsRead.NotificationBell.tsxto render a slide-in drawer from the right side, newest-first notification order, distinct event icons for each event type, and automatic unread badge clearing on open.3. Share to Twitter / X Button (#797)
shareTwitter.utils.tsto format tweet text (Just bought [CreatorName] keys on AccessLayer at [price] XLM. Buy here: [referral link]) and Twitter intent URL.ShareTwitterButton.tsxwhich opens Twitter intent in a new tab, falls back to plain key URL if no referral link exists, and renders only for authenticated holders (quantity > 0).ShareTwitterButtononCreatorDetailPage.tsxbelow creator stats cards.Verification & Testing
Unit & Integration Tests Passed (36/36)
src/components/creator/__tests__/CoCreatorSection.test.tsx(6 tests)src/components/common/__tests__/NotificationBell.test.tsx(15 tests)src/hooks/__tests__/useNotifications.test.ts(6 tests)src/components/common/__tests__/ShareTwitterButton.test.tsx(6 tests)src/pages/__tests__/CreatorDetailPage.integration.test.tsx(3 tests)Checklist
pnpm checkpassed)