Add integration test for admin function reverts leaving protocol config values unchanged - #654
Merged
Chucks1093 merged 8 commits intoAug 1, 2026
Conversation
|
@baedboibidex-cmyk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…ig values unchanged (accesslayerorg#651) - Add assert_is_admin check to set_fee_config so non-admin callers are rejected - Add assert_is_admin check to set_protocol_fee_recipient so non-admin callers are rejected - Add 4 new tests in admin_unauthorized.rs covering both set_fee_config and set_protocol_fee_recipient non-admin revert scenarios with state-change assertions - Update contract_test_env helpers to register protocol admin before calling admin functions - Update 20 existing test files to register protocol admin before admin-gated calls
- set_protocol_admin now required before set_fee_config/set_protocol_fee_recipient - register admin in test_issues and protocol_admin integration tests - fix fmt + clippy in admin_unauthorized (drop unused import, invalid unwrap)
Main landed tests that call set_fee_config/set_protocol_fee_recipient on a fresh contract without bootstrapping the protocol admin, so the new assert_is_admin guard on those functions reverts them with Unauthorized. Set the admin before the guarded calls in the affected tests.
baedboibidex-cmyk
force-pushed
the
test/admin-revert-config-leaves-protocol-config-unchanged
branch
from
August 1, 2026 14:49
9ef83bd to
04d9907
Compare
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #651
Adds assert_is_admin checks to set_fee_config and set_protocol_fee_recipient, plus integration tests verifying protocol config values remain unchanged when non-admin wallets attempt admin operations.