Skip to content

Conversation

@marandmart
Copy link
Contributor

@marandmart marandmart commented Oct 31, 2025

Brief summary of changes

  • Adjust visual elements of certain modules used in the candidate profile page to make them not break under small window width sizes and to use more of the available space.
  • Defined a max height limit for the panel that can be customized via props.
  • Adjusted viewing of panel widgets on screen size of 576px and bellow.

Solves issue: https://github.com/aces/CBIGR/issues/559
Example page: candidate_profile/587630/

Before:
Screenshot 2025-10-31 at 11 20 23 AM

After:
Screenshot 2025-10-31 at 11 20 54 AM

Before:
Screenshot 2025-10-31 at 11 45 23 AM

After:
Screenshot 2025-10-31 at 11 45 29 AM

Before:
Screenshot 2025-10-31 at 11 23 08 AM

After:
Screenshot 2025-10-31 at 11 23 13 AM

Before:
Screenshot 2025-10-31 at 11 24 03 AM

After:
Screenshot 2025-10-31 at 11 24 06 AM

Before:
Screenshot 2025-11-03 at 10 07 04 AM

After:
Screenshot 2025-11-03 at 10 07 20 AM

Before:
chrome-capture-2025-11-03
chrome-capture-2025-11-03 (1)

After:
image
Screenshot 2025-11-03 at 10 19 25 AM

@github-actions github-actions bot added Language: Javascript PR or issue that update Javascript code Module: candidate_profile PR or issue related to candidate_profile module Module: instruments PR or issue related to instruments module Module: media PR or issue related to media module labels Oct 31, 2025
@ridz1208 ridz1208 added the State: Needs work PR awaiting additional work by the author to proceed label Oct 31, 2025
driusan
driusan previously approved these changes Oct 31, 2025
@driusan driusan dismissed their stale review October 31, 2025 16:36

Just noticed the "Needs work" tag..

@ridz1208
Copy link
Collaborator

@driusan I think one of the last taks was a weirdness about the height of the panels, in some cases they stretched to infinity taking over their entire column and in mobile view I suggested the panels to go into one column because it didnt make any sense on a tight enough screen.

@marandmart marandmart removed the State: Needs work PR awaiting additional work by the author to proceed label Nov 3, 2025
@charliehenrib
Copy link
Contributor

@marandmart before clicking on a candidate, there is the filter table having weird dimensions:
image

@charliehenrib
Copy link
Contributor

charliehenrib commented Nov 14, 2025

Can the "l" fit with the rest of the project name:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Javascript PR or issue that update Javascript code Module: candidate_profile PR or issue related to candidate_profile module Module: instruments PR or issue related to instruments module Module: media PR or issue related to media module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants