Skip to content

feat(signing): v3-identity Tier 1 — BrandJsonJwksResolver + CapabilityCache (port from JS) #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 2 commits into from
May 2, 2026
Merged

feat(signing): v3-identity Tier 1 — BrandJsonJwksResolver + CapabilityCache (port from JS) #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffd522b
feat(signing): port BrandJsonJwksResolver + CapabilityCache + capabil…
bokelley May 2, 2026
fb65e12
fix(signing): address expert review on PR #345 — SSRF, body cap, URL …
bokelley May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
659 changes: 659 additions & 0 deletions docs/proposals/v3-identity-bundle-design.md
View file
Open in desktop

Large diffs are not rendered by default.

28 changes: 28 additions & 0 deletions src/adcp/signing/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,30 @@
SigningDecision,
operation_needs_signing,
)
from adcp.signing.brand_jwks import (
BrandAgentType,
BrandJsonJwksResolver,
BrandJsonResolverError,
BrandJsonResolverErrorCode,
)
from adcp.signing.canonical import (
SignatureInputLabel,
build_signature_base,
canonicalize_authority,
canonicalize_target_uri,
parse_signature_input_header,
)
from adcp.signing.capability_cache import (
CachedCapability,
CapabilityCache,
build_capability_cache_key,
default_capability_cache,
)
from adcp.signing.capability_priming import (
CAPABILITY_OP,
NEGATIVE_CACHE_TTL_SECONDS,
ensure_capability_loaded,
)
from adcp.signing.client import (
CapabilityProvider,
install_signing_event_hook,
Expand Down Expand Up @@ -255,8 +272,15 @@ def __init__(self, *args: object, **kwargs: object) -> None:
"AsyncJwksFetcher",
"AsyncJwksResolver",
"AsyncRevocationListFetcher",
"BrandAgentType",
"BrandJsonJwksResolver",
"BrandJsonResolverError",
"BrandJsonResolverErrorCode",
"CAPABILITY_OP",
"CachedCapability",
"CachingJwksResolver",
"CachingRevocationChecker",
"CapabilityCache",
"CapabilityProvider",
"DEFAULT_ALLOWED_PORTS",
"DEFAULT_EXPIRES_IN_SECONDS",
Expand All @@ -273,6 +297,7 @@ def __init__(self, *args: object, **kwargs: object) -> None:
"JwsSignatureInvalidError",
"JwsUnknownKeyError",
"MAX_WINDOW_SECONDS",
"NEGATIVE_CACHE_TTL_SECONDS",
"NONCE_BYTES",
"PgReplayStore",
"REQUEST_SIGNATURE_ALG_NOT_ALLOWED",
Expand Down Expand Up @@ -325,14 +350,17 @@ def __init__(self, *args: object, **kwargs: object) -> None:
"b64url_decode",
"b64url_encode",
"build_async_ip_pinned_transport",
"build_capability_cache_key",
"build_ip_pinned_transport",
"build_signature_base",
"canonicalize_authority",
"canonicalize_target_uri",
"compute_content_digest_sha256",
"content_digest_matches",
"default_capability_cache",
"default_jwks_fetcher",
"default_revocation_list_fetcher",
"ensure_capability_loaded",
"extract_signature_bytes",
"format_signature_header",
"generate_signing_keypair",
Expand Down
Loading
Loading