ci: refresh TypeScript reference seller pin#2125
Merged
Merged
Conversation
There was a problem hiding this comment.
LGTM. Workflow-only pin refresh, both call sites moved in lockstep.
Things I checked
- Pinned commit
df7b5837exists onmainand corresponds to@adcp/sdk@8.1.0-beta.17(verifiedpackage.jsonat that SHA). - Both occurrences updated: matrix row at
.github/workflows/interop-python.yml:111and the summary note at:280. No stalebeta.12reference left in the workflow. - No
src/lib/,bin/,scripts/, or published-files surface touched — no changeset required. - Validation block in the PR body covers the storyboard harness, workflow lint, and commitlint.
Safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The TypeScript seller in current main already passes the rc4 storyboard. The release warning came from the workflow matrix checking out an older pinned TypeScript reference seller commit that still fails two media-buy storyboard assertions under the current SDK runner.
Validation