Skip to content

ci: refresh TypeScript reference seller pin#2125

Merged
bokelley merged 1 commit into
mainfrom
fix/ts-reference-seller-rc4-storyboards
May 30, 2026
Merged

ci: refresh TypeScript reference seller pin#2125
bokelley merged 1 commit into
mainfrom
fix/ts-reference-seller-rc4-storyboards

Conversation

@bokelley
Copy link
Copy Markdown
Contributor

Summary

  • updates the release interop TypeScript reference seller pin from the stale beta.12 commit to the known-good beta.17 release commit
  • updates the workflow summary note to match the new pin

Root cause

The TypeScript seller in current main already passes the rc4 storyboard. The release warning came from the workflow matrix checking out an older pinned TypeScript reference seller commit that still fails two media-buy storyboard assertions under the current SDK runner.

Validation

  • ADCP_SKIP_NPM_CI=1 ADCP_SKIP_BUILD=1 ./scripts/ci/run_storyboard_reference_seller.sh
  • npm run lint:workflows
  • git diff --check
  • npx commitlint --from origin/main --to HEAD --verbose
  • pre-push typecheck/build

Copy link
Copy Markdown

@aao-ipr-bot aao-ipr-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Workflow-only pin refresh, both call sites moved in lockstep.

Things I checked

  • Pinned commit df7b5837 exists on main and corresponds to @adcp/sdk@8.1.0-beta.17 (verified package.json at that SHA).
  • Both occurrences updated: matrix row at .github/workflows/interop-python.yml:111 and the summary note at :280. No stale beta.12 reference left in the workflow.
  • No src/lib/, bin/, scripts/, or published-files surface touched — no changeset required.
  • Validation block in the PR body covers the storyboard harness, workflow lint, and commitlint.

Safe to merge.

@bokelley bokelley merged commit ba58433 into main May 30, 2026
30 checks passed
@bokelley bokelley deleted the fix/ts-reference-seller-rc4-storyboards branch May 30, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant