This repository was archived by the owner on Mar 15, 2026. It is now read-only.
Add batch preview and HTML output support#31
Merged
Conversation
Add batch mode (1-50 creatives in one call) and HTML output format to preview_creative tool, implementing the new ADCP spec from PR #183. Batch mode enables 5-10x faster preview generation for format showcases and campaign review grids. HTML output mode eliminates storage overhead by returning preview_html directly instead of uploading to S3. Maintains full backward compatibility with existing URL-based preview mode. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add comprehensive documentation for new batch mode and HTML output features in examples/README.md, including: - React example using batch preview with HTML output for format showcases - When to use batch mode vs single mode - When to use HTML output vs URL output - Batch + HTML combined example with error handling - Per-request output format override examples - Batch mode response structure documentation - HTML output response structure documentation This addresses the original question about making grids work without persistence - batch mode with HTML output is the perfect solution. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Handle case where result.structured_content can be None by defaulting to empty dict. This fixes the CI failure:
- src/creative_agent/server.py:429:16: error: Unsupported right operand type for in ("dict[str, Any] | None")
- src/creative_agent/server.py:435:40: error: Value of type "dict[str, Any] | None" is not indexable
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements batch mode (1-50 creatives in single call) and HTML output format for preview_creative, as specified in ADCP PR #183. Batch mode enables 5-10x faster preview generation. HTML output eliminates S3 storage overhead by returning preview_html directly.
Changes
preview_htmldirectly (no storage/cleanup needed)Testing
🤖 Generated with Claude Code