-
Notifications
You must be signed in to change notification settings - Fork 42
feat(whatsnew): add what's new nav button and dialog #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,460
−28
Merged
Changes from all commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
320e7bb
feat(whatsnew): add what's new nav trigger and dialog
3c27479
test(nav): temporarily force-inject whatsnew on my test page
9b1650c
test: reorder nav injection after Feedback, fetch from preview host
d294ccc
style(whatsnew): match Figma TOC styling exactly
a8431ee
fix(whatsnew): always show CTA, scroll offset, dot lifecycle, spacing
4e7c810
fix(whatsnew): sliding toc indicator, scoped disabled button, spacing
2981b75
fix(whatsnew): reposition close button, inset cards scrollbar
ab22b61
style(whatsnew): give cards scrollbar a visible track, matching toc's
e7c5253
fix(whatsnew): flatten scrollbar selectors, higher-contrast colors, s…
a636ee0
fix(whatsnew): custom auto-hiding cards scrollbar, fix bottom spacing
5438b5a
revert(whatsnew): drop custom cards scrollbar, back to native
10cb89b
style(whatsnew): drop panel border, inset scrollbar 40px from bottom
d1f5b12
style(whatsnew): add 20px more trailing space after the last card
076aec8
fix(whatsnew): guarantee last-card scroll room, fix scrollbar inset
a628647
fix(whatsnew): precise trailing space, remove static bottom gap again
50f5d9d
feat(whatsnew): timestamp-based freshness, drop CTAs, responsive mobile
1927f7f
fix(whatsnew): toc indicator now moves immediately on click
7730dcb
fix(whatsnew): suppress scroll observer during click-triggered scroll
6326e04
fix(whatsnew): fire toc indicator update at full card visibility too
5c61278
fix(whatsnew): remove mobile-only white gap above cards
abca7ac
feat(whatsnew): mobile toc sticks over cards instead of a static gap
8da23b5
fix(whatsnew): restore mobile card width, regressed by sticky-toc change
f0d7551
fix(whatsnew): symmetric 40px left/right padding on mobile cards panel
e604437
refactor(whatsnew): move whatsnew-flags into blocks/whatsnew
8a705f4
fix(whatsnew): use a relative path for the fragment, not a hardcoded …
c6ae7fb
refactor(whatsnew): use shared nx-dialog instead of a raw <dialog>
a922f5f
fix(whatsnew): fill actual available height, fix close button stacking
0311c89
fix(whatsnew): properly fix gray background height, stop toc scrolling
dc301a9
fix(whatsnew): pin panel height with min-height, drop magic-number hack
1482585
fix(whatsnew): kill outer body's gap/actions space and overflow
24e5720
revert: drop nx-dialog refactor, back to raw <dialog>
dc0f032
fix(whatsnew): handle fetch failures in _loadContent
da7ada7
fix(whatsnew): stop double-fetching the same fragment URL
35703d6
fix(whatsnew): scrollspy could get stuck suppressed forever
b635eb7
fix(whatsnew): guard against stacking two dialogs
d48dd09
test(whatsnew): add unit tests for parsing, dialog, and nav trigger
ef9868e
refactor(whatsnew): reuse nx-dialog per review feedback
47df861
fix(whatsnew): cards weren't scrolling, .wn-body ignored its height cap
97600e5
style(whatsnew): use component text tokens for card body, not body to…
c946003
fix(whatsnew): symmetric top/bottom padding on desktop cards viewport
0e2fba8
fix(whatsnew): last card couldn't reach the scroll target on click
f5f8ca7
fix(whatsnew): scope the extra bottom gap to the last card only
221b761
fix(whatsnew): restore focus to trigger on close, extract nav constant
69ac04e
fix(whatsnew): toc indicator invisible on initial open
fc82a0e
fix(whatsnew): dot clears on full view, not just close; drop define g…
9fbb81b
fix(whatsnew): suppress focus ring on mouse-triggered close only
094cfa8
fix(whatsnew): stop autofocusing the close button on auto-open
f92689a
style(whatsnew): condense multi-line comments to single lines
2d9ee92
fix(whatsnew): use the gift icon Markus requested, not lightbulb
0ae23e1
fix(whatsnew): last card requires scrolling to bottom to count as seen
44ffc47
Merge branch 'main' into new1140
yevheniia0831 19be8dc
feat(whatsnew): support MP4 video entries, not just pictures
029b40f
fix(whatsnew): huge bottom padding on mobile and with video cards
5fec4d7
fix(whatsnew): make mobile popup a true full-screen modal
83480fc
Revert "fix(whatsnew): make mobile popup a true full-screen modal"
6cf1a0d
fix(nx2): give nx2's Adobe Clean font a collision-proof family name
c403780
Revert "fix(nx2): give nx2's Adobe Clean font a collision-proof famil…
83d04fc
Update whatsnew trigger behavior
mhaack 8d08f28
Simplify whatsnew seen-state handling
mhaack f2bb7b3
fix: remove unused
mhaack b2915ed
Remove unused whatsnew gift icon
mhaack 7c44003
Rename whatsnew helpers
mhaack a229b96
Simplify whatsnew dialog scrolling
mhaack 15d8562
Clean up whatsnew tests
mhaack 554f703
Narrow whatsnew fragment loading
mhaack 4ab1a9e
Clean up whatsnew test comments
mhaack 9d20998
Revert whatsnew changes from fragment loader
mhaack d0d9ffc
Make whatsnew parser internals private
mhaack 05a72c8
Trim whatsnew test helpers
mhaack 6b747de
fix(whatsnew): replace JS scroll-room calc with static CSS padding
301d6d7
fix(whatsnew): reduce static scroll padding, 240px overshot
cbc21ff
fix(whatsnew): don't zero out mobile scroll padding
6fd4124
fix(whatsnew): drop unnecessary --nx-dialog-body-overflow override
8eb8d16
fix(whatsnew): drop unused flex on .wn-card
7595f67
fix(whatsnew): use heading-size-xs for toc title
ee4a0a3
fix(whatsnew): bump toc title back up to heading-size-s, xs looked to…
eafc961
fix(whatsnew): revert toc title back to heading-size-m
375406e
Merge branch 'main' into new1140
yevheniia0831 e077c9c
fix(whatsnew): drop custom scrollbar styling, use native
f17566d
fix(whatsnew): set explicit font-family on toc items, card titles/body
6c3a4cf
fix(whatsnew): scope focus-tracking listeners to dialog lifecycle
83ba73b
fix(whatsnew): rely on native dialog focus restore, cap size only
cb9908d
Update worklog
claude 1db1c8c
fix(whatsnew): restore dialog min size
8992629
Update worklog
claude dc721b8
feat(dialog): add large size variant, size whatsnew to its content
c05cbf6
Update worklog
claude 334a4d6
Use shared whatsnew fragment path
mhaack 5f0aa4c
fix(whatsnew): stop toc indicator bouncing while scrolling
1464146
Update worklog
claude 42b738a
Merge branch 'main' into new1140
528bb8d
fix: cleanup shared dialog updates
sharanyavinod 5155525
Merge branch 'main' into new1140
sharanyavinod d4e5a18
chore: add missing aria-label
sharanyavinod b06e152
Merge branch 'new1140' of github-new:adobe/da-nx into new1140
sharanyavinod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes will impact all dialogs. are we sure this is has no side effects.