Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

ENH: accept tf.data.Dataset inputs - #166

Open
adriangb wants to merge 7 commits into
masterfrom
non-array-inputs
Open

ENH: accept tf.data.Dataset inputs#166
adriangb wants to merge 7 commits into
masterfrom
non-array-inputs

Conversation

@adriangb

Copy link
Copy Markdown
Owner

Partially addresses #160 by enabling direct tf.data.Dataset inputs.

This mainly enables the use case where a user has an existing Dataset and Model and would like to use GridSearch or something on it, but most of the rest of the SciKeras and Sklearn features will be unavailable including:

  • Encoding/decoding of labels to allow strings, obj, etc.
  • Ability to dynamically adapt Model inputs/outputs to data

And this requires using BaseWrapper directly, or alternatively subclassing KerasClassifier or KerasRegressor to disable the transformers.

@codecov-io

codecov-io commented Jan 16, 2021

Copy link
Copy Markdown

Codecov Report

Merging #166 (79620cd) into master (f4a9fef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files           6        6           
  Lines         672      679    +7     
=======================================
+ Hits          669      676    +7     
  Misses          3        3           
Impacted Files Coverage Δ
scikeras/wrappers.py 99.45% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a9fef...79620cd. Read the comment docs.

@github-actions

github-actions Bot commented Jan 29, 2021

Copy link
Copy Markdown

📝 Docs preview for commit 79620cd at: https://www.adriangb.com/scikeras/refs/pull/166/merge/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants