feat: ngify#93
Open
alandtse wants to merge 7 commits intoaers:masterfrom
Open
Conversation
Port EngineFixesSkyrim64 to a single unified DLL targeting SE 1.5.97, AE 1.6.x, and VR 1.4.15 using CommonLib-NG.
…bmodule Replace raw magic numbers with named enum constants now exposed by the updated CommonLibSSE submodule (alandtse/CommonLibVR b8c2fb0): - BSLightingAmbientSpecular: 0x20000/0x200 → TechniqueFlag::kAmbientSpecular/kSpecular - BSLightingShaderForceAlphaTest: remove local raw constants, use BSShaderMaterial::Feature + TechniqueFlag::kDoAlphaTest + kTechniqueIDBase - BSLightingShaderParallaxBug: 0x3 → Feature::kParallax - MemoryAccessErrors: 12 → DataID::kTotal, array index → DataID::kParticleDensity - MusicOverlap: correct vtable source BGSMusicType::VTABLE[1] → BSIMusicType::VTABLE[0] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
VR lacks the caller-side parent-cell null checks that SE added to IsPlayerInRegion. Patch at REL::ID(21322)+0x22 to load the player singleton, guard both the player pointer and its parent cell before calling GetRegionList, and skip cleanly if either is null. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- bGetKeywordItemCount: default true → false (fix has known side-effects) - bCleanSKSECoSaves: default false → true (safe cleanup, on by default) - bDupeAddonNodes (VR): default false → true; improve description Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ScrapHeap and MemoryManager both redirect to TBB; using them independently causes alloc/free type mismatches that crash. Remove the separate bOverrideScrapHeap setting and always install ScrapHeap inside the bOverrideMemoryManager branch. Update save_game_max_size guard and config files accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Leaving this here in case you're interested. Otherwise I'll just keep the port for Engine Fixes VR. |
Switches submodule from lazy_esl branch to ng tip (42c65076f). ng 4.14.0 includes TechniqueFlag enum and kTechniqueIDBase for BSLightingShader, fixing the build failure in bslightingambientspecular and bslightingshader_force_alpha_test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rLoadedGameLimit Keys were registered as "bRefrMainMenuLimit"/"bRefrLoadedGameLimit" (wrong b prefix for U32 values), so user edits to those TOML entries had no effect. Defaults happened to match so no runtime impact, but the TOML was silently ignored. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port EngineFixesSkyrim64 to a single unified DLL targeting SE 1.5.97,
AE 1.6.x, and VR 1.4.15 using CommonLib-NG.