-
Notifications
You must be signed in to change notification settings - Fork 304
build: pin ko base images by digest #1500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Grant McCloskey (MushuEE)
wants to merge
1
commit into
agent-substrate:main
Choose a base branch
from
MushuEE:build/pin-ko-base-images
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−5
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| #!/usr/bin/env bash | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we need a defensive script for this. PR review should be sufficient. These cost time on every PR and we're already tight on CI resources. |
||
|
|
||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # Fails if any base image in .ko.yaml is not pinned by digest. A tag-only base | ||
| # makes the build depend on when it runs: the same commit built a week apart | ||
| # would produce different images. See the header comment in .ko.yaml. | ||
|
|
||
| set -o errexit -o nounset -o pipefail | ||
|
|
||
| ROOT="$(git rev-parse --show-toplevel)" | ||
| cd "${ROOT}" | ||
|
|
||
| # Image refs are the values of defaultBaseImage and of every entry under | ||
| # baseImageOverrides. Both are `key: value` lines; comments and blank lines | ||
| # are dropped. defaultPlatforms entries are list items and never match. | ||
| refs="$(sed -e 's/#.*$//' .ko.yaml \ | ||
| | awk ' | ||
| /^defaultBaseImage:/ { print $2; next } | ||
| /^baseImageOverrides:/ { in_overrides = 1; next } | ||
| /^[^[:space:]]/ { in_overrides = 0 } | ||
| in_overrides && NF >= 2 { print $NF } | ||
| ')" | ||
|
|
||
| if [[ -z "${refs}" ]]; then | ||
| echo "error: no base image refs found in .ko.yaml" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| rc=0 | ||
| while IFS= read -r ref; do | ||
| if [[ ! "${ref}" =~ @sha256:[0-9a-f]{64}$ ]]; then | ||
| echo "error: .ko.yaml base image is not pinned by digest: ${ref}" >&2 | ||
| rc=1 | ||
| fi | ||
| done <<< "${refs}" | ||
|
|
||
| if [[ "${rc}" -ne 0 ]]; then | ||
| echo "Pin every base image as <image>:<tag>@sha256:<digest> (see .ko.yaml)." >&2 | ||
| fi | ||
| exit "${rc}" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need the comments to justify pinning by SHA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, we pin by sha for most images in the repo without any comment.
Also, are we sure these digests point at the tag we specified, if an agent generated this?
This is the sort of PR I would 100% hand generate. You can use
crane digeston the intended image for TOFU.