Skip to content

demos/counter: improve atomic use and parse duration as int64 #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maya Wang (mayawang) merged 1 commit into from
Sep 8, 2026
+5 −5
Merged

demos/counter: improve atomic use and parse duration as int64 #1506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions demos/counter/counter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import (
)

var (
requestCount uint64
requestCount atomic.Uint64
ready atomic.Bool
fileMutex sync.Mutex
sigtermSleepDurationSecs atomic.Int64
Expand Down Expand Up @@ -89,7 +89,7 @@ func main() {
defaultMux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
ctx := r.Context()
fileCounter := incrementFileCounter(filepath.Join(*fileCounterDirectory, "a.txt"))
memoryCounter := atomic.AddUint64(&requestCount, 1)
memoryCounter := requestCount.Add(1)
currentIP := getCurrentIP()

fileContentStr := ""
Expand Down Expand Up @@ -137,14 +137,14 @@ func main() {
http.Error(w, "missing duration parameter", http.StatusBadRequest)
return
}
d, err := strconv.Atoi(durationStr)
d, err := strconv.ParseInt(durationStr, 10, 64)
if err != nil || d < 0 {
http.Error(w, "invalid duration parameter", http.StatusBadRequest)
return
}
sigtermSleepDurationSecs.Store(int64(d))
sigtermSleepDurationSecs.Store(d)
response := fmt.Sprintf("SIGTERM sleep duration set to %d seconds\n", d)
slog.InfoContext(r.Context(), "Updated SIGTERM sleep duration", slog.Int("duration_secs", d))
slog.InfoContext(r.Context(), "Updated SIGTERM sleep duration", slog.Int64("duration_secs", d))
w.WriteHeader(http.StatusOK)
w.Write([]byte(response))
})
Expand Down
Loading