tests: add tree-sitter highlight to catch invalid node type#137
Open
katrinafyi wants to merge 1 commit intomainfrom
Open
tests: add tree-sitter highlight to catch invalid node type#137katrinafyi wants to merge 1 commit intomainfrom
tree-sitter highlight to catch invalid node type#137katrinafyi wants to merge 1 commit intomainfrom
Conversation
if tree-sitter is available, it will raise an error if the highlights
file has outdated node references
```
Error in query file ./queries/highlights.scm
Caused by:
Query error at 93:2. Invalid node type blah
```
tree-sitter tests still don't run in CI, but it means that if someone
is working on the tree-sitter, they'll probably be able to see this
error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if tree-sitter is available, it will raise an error if the highlights file has outdated node references
tree-sitter tests still don't run in CI, but it means that if someone is working on the tree-sitter, they'll probably be able to see this error.
In future, this should prevent #134