Skip to content

refactor(dir/store): flatten store config and move name verification to naming#1527

Open
paralta wants to merge 2 commits into
mainfrom
refactor/store-config
Open

refactor(dir/store): flatten store config and move name verification to naming#1527
paralta wants to merge 2 commits into
mainfrom
refactor/store-config

Conversation

@paralta
Copy link
Copy Markdown
Member

@paralta paralta commented May 20, 2026

Simplify config before #1490.

OCI is the only supported store backend, so the store.provider field and the store.oci.* nesting are gone. store.oci.* is now store.* everywhere (Go, YAML, Helm, env vars), and store.verification.enabled moves to naming.enabled next to naming.ttl.

Warning

Breaking config changes — update your config before redeploying:

  • YAML: drop store.provider; rename store.oci.<field>store.<field>; rename store.verification.enablednaming.enabled.
  • Env vars: drop DIRECTORY_SERVER_STORE_PROVIDER; rename DIRECTORY_SERVER_STORE_OCI_*DIRECTORY_SERVER_STORE_*; rename DIRECTORY_SERVER_STORE_VERIFICATION_ENABLEDDIRECTORY_SERVER_NAMING_ENABLED.
  • Helm values: drop apiserver.config.store.provider; rename apiserver.config.store.oci.<field>apiserver.config.store.<field>.
  • Go callers: server/store/config is deleted — read cfg.Store.<field> instead of cfg.Store.OCI.<field>.
  • Deleted server/store/config; server.Config.Store is oci.Config directly and store.New calls oci.New with no provider switch.
  • Moved store.verification.enabled to naming.enabled (default true) next to naming.ttl.
  • Flattened store.oci.*store.* in cli/cmd/daemon/daemon.config.yaml, every e2e/integration testenv, install/docker/apiserver.env, and the Helm chart values, templates, and configmap.
  • Updated callers (server/controller/sync.go, server/routing/test_utils.go, tests/integration/server/setup.go, cli/cmd/daemon/{config,start,daemon_test}.go) to read cfg.Store.<field> and rebound viper keys to server.store.*.
  • Renamed env vars in server/config/config_test.go and deployment.yaml from DIRECTORY_SERVER_STORE_OCI_* to DIRECTORY_SERVER_STORE_*.

paralta added 2 commits May 20, 2026 10:22
…nfig

Signed-off-by: Catarina Paralta <clouropa@cisco.com>
…efix and updating related references

Signed-off-by: Catarina Paralta <clouropa@cisco.com>
@github-actions
Copy link
Copy Markdown
Contributor

The latest Buf updates on your PR. Results from workflow Buf CI / verify-proto (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped⏩ skipped✅ passedMay 20, 2026, 9:28 AM

@github-actions github-actions Bot added the size/M Denotes a PR that changes 200-999 lines label May 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
server/store/store.go 50.0% 1 Missing and 1 partial ⚠️
cli/cmd/daemon/start.go 80.0% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@paralta paralta marked this pull request as ready for review May 20, 2026 13:59
@paralta paralta requested a review from a team as a code owner May 20, 2026 13:59
@paralta paralta modified the milestone: DIR v1.4 May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 200-999 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant