refactor(dir/store): flatten store config and move name verification to naming#1527
Open
paralta wants to merge 2 commits into
Open
refactor(dir/store): flatten store config and move name verification to naming#1527paralta wants to merge 2 commits into
paralta wants to merge 2 commits into
Conversation
…nfig Signed-off-by: Catarina Paralta <clouropa@cisco.com>
…efix and updating related references Signed-off-by: Catarina Paralta <clouropa@cisco.com>
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / verify-proto (pull_request).
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify config before #1490.
OCI is the only supported store backend, so the
store.providerfield and thestore.oci.*nesting are gone.store.oci.*is nowstore.*everywhere (Go, YAML, Helm, env vars), andstore.verification.enabledmoves tonaming.enablednext tonaming.ttl.Warning
Breaking config changes — update your config before redeploying:
store.provider; renamestore.oci.<field>→store.<field>; renamestore.verification.enabled→naming.enabled.DIRECTORY_SERVER_STORE_PROVIDER; renameDIRECTORY_SERVER_STORE_OCI_*→DIRECTORY_SERVER_STORE_*; renameDIRECTORY_SERVER_STORE_VERIFICATION_ENABLED→DIRECTORY_SERVER_NAMING_ENABLED.apiserver.config.store.provider; renameapiserver.config.store.oci.<field>→apiserver.config.store.<field>.server/store/configis deleted — readcfg.Store.<field>instead ofcfg.Store.OCI.<field>.server/store/config;server.Config.Storeisoci.Configdirectly andstore.Newcallsoci.Newwith no provider switch.store.verification.enabledtonaming.enabled(defaulttrue) next tonaming.ttl.store.oci.*→store.*incli/cmd/daemon/daemon.config.yaml, every e2e/integration testenv,install/docker/apiserver.env, and the Helm chart values, templates, and configmap.server/controller/sync.go,server/routing/test_utils.go,tests/integration/server/setup.go,cli/cmd/daemon/{config,start,daemon_test}.go) to readcfg.Store.<field>and rebound viper keys toserver.store.*.server/config/config_test.goanddeployment.yamlfromDIRECTORY_SERVER_STORE_OCI_*toDIRECTORY_SERVER_STORE_*.