CLI CPPPATH/LIBPATH/LINKFLAGS to scons env#324
Open
dorogyn22 wants to merge 1 commit intoahay:masterfrom
Open
Conversation
Variables like CPPPATH or LIBPATH passed on the configure command (./configure) prior to scons install are accepted without error but never applied to the build bc they are not registered with opts.Add(). path_get() in configure.py already supports comma-separated strings but never receives them. Read these variables from ARGUMENTS and apply them to env directly. Also forward OMPI_CC/OMPI_CXX to child processes so Open MPI compiler wrappers use the correct compiler (e.g. LLVM clang with OpenMP support instead of Apple system clang).
Contributor
|
This might be better handled in https://github.com/ahay/src/blob/master/framework/configure.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variables like CPPPATH or LIBPATH passed on the configure command (./configure) prior to scons install are accepted without error but never applied to the build bc they are not registered with opts.Add().
path_get() in configure.py already supports comma-separated strings but never receives them.
Read these variables from ARGUMENTS and apply them to env directly. Also forward OMPI_CC/OMPI_CXX to child processes so Open MPI compiler wrappers use the correct compiler (e.g. LLVM clang with OpenMP support instead of Apple system clang).