Merge duplicate Badger Face/Faced Welsh Mountain sheep terms#74
Open
allenbaron wants to merge 1 commit intomainfrom
Open
Merge duplicate Badger Face/Faced Welsh Mountain sheep terms#74allenbaron wants to merge 1 commit intomainfrom
allenbaron wants to merge 1 commit intomainfrom
Conversation
This commit merges VBO:0001309 (Badger Face Welsh Mountain) into VBO:0001310 (Badger Faced Welsh Mountain) as they represent the same breed. Changes: - Obsoleted VBO:0001309 with replaced_by: VBO:0001310 - Merged all synonyms from VBO:0001309 into VBO:0001310 - Added LBO:0000661 xref to VBO:0001310 - Added origin description to VBO:0001310 - Updated geographic variant VBO:0014179 (Netherlands) to reference VBO:0001310 - Added "Badger Face Welsh Mountain" synonym to VBO:0014180 (UK) Evidence supporting this merge: - Scientific literature (PMID:26091804) uses both spellings interchangeably - Only ONE official breed society exists (Badger Face Welsh Mountain Sheep Society) - FAO DAD-IS uses both spellings for the same breed - Welsh name: Defaid Idloes - Two color varieties (Torddu and Torwen) are morphs, not separate breeds Fixes #71 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates duplicate ontology terms for the Badger Face/Faced Welsh Mountain sheep breed by obsoleting VBO:0001309 and merging its content into VBO:0001310.
- Obsoleted VBO:0001309 ("Badger Face Welsh Mountain") as a duplicate of VBO:0001310
- Enhanced VBO:0001310 with all synonyms, cross-references, and metadata from both terms
- Updated geographic variant relationships to reference the retained term
Comment on lines
+18192
to
+18195
| name: obsolete Badger Face Welsh Mountain (Sheep) | ||
| is_obsolete: true | ||
| replaced_by: VBO:0001310 | ||
| property_value: IAO:0000233 "https://github.com/monarch-initiative/vertebrate-breed-ontology/issues/71" xsd:anyURI |
There was a problem hiding this comment.
Consider adding the IAO:0000231 property to indicate the reason for obsolescence. Other obsolete terms in the codebase follow this pattern. For example:
property_value: IAO:0000231 "terms merged" xsd:string
This property provides metadata about why the term was obsoleted, which is helpful for ontology users and maintainers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR merges two duplicate terms for the same Welsh sheep breed:
Changes Made
1. Obsoleted VBO:0001309
is_obsolete: truereplaced_by: VBO:00013102. Enhanced VBO:0001310
xref: LBO:0000661origindescription: "local indigenous breed of Wales"3. Updated Geographic Variants
Evidence Supporting This Merge
Scientific Literature
Official Sources
Breed Characteristics
Validation
✅ Syntax validation passed:
robot convertcompleted without errors✅ All geographic variants updated to reference retained term
✅ All synonyms and xrefs preserved and merged
Related Issues
Fixes #71
🤖 Generated with Claude Code