Skip to content

fix(release): use local commits for release window - #2022

Merged
hshoff merged 1 commit into
masterfrom
harry/visx-release-local-commits
Jun 18, 2026
Merged

fix(release): use local commits for release window#2022
hshoff merged 1 commit into
masterfrom
harry/visx-release-local-commits

Conversation

@hshoff

@hshoff hshoff commented Jun 18, 2026

Copy link
Copy Markdown
Member

Why use local commits for the release window?

The push workflow for PR #2021 still failed in the release step after retrying GitHub's compare endpoint three times.

The workflow checks out full git history with fetch-depth: '0', so the release script does not need the compare endpoint just to enumerate commit SHAs between the latest reachable tag and HEAD.

馃挜 Breaking Changes

  • None.

馃殌 Enhancements

  • None.

馃摑 Documentation

  • None.

馃悰 Bug Fix

  • Use local git rev-list --reverse <tag>..HEAD output to build the release commit window instead of fetching the same commit list from GitHub's compare endpoint.

馃彔 Internal

  • Keep GitHub API usage for commit-to-PR lookup, release creation, and release comments, where GitHub metadata is still needed.

Validation

  • yarn lint
  • git diff --check

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the release workflow by removing reliance on GitHub鈥檚 compare endpoint for enumerating commits in the release window, instead deriving the commit list locally from the checked-out git history.

Changes:

  • Switch release commit enumeration to git rev-list --reverse <tagSha>..HEAD rather than GET /compare.
  • Update the release script call sites to use the new fetchCommitsSinceTag(tagSha) signature (no GitHub client required).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
scripts/performRelease/index.ts Updates callers to use the local commit-window helper (no Octokit client passed).
scripts/performRelease/fetchCommitsSinceTag.ts Replaces GitHub compare API usage with a local git rev-list-based implementation returning a compatible { data: { commits } } shape.

馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/performRelease/index.ts Outdated
@hshoff
hshoff force-pushed the harry/visx-release-local-commits branch from a6c6593 to 32a05a0 Compare June 18, 2026 17:50
@hshoff
hshoff merged commit c75aa15 into master Jun 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants