fix(release): use local commits for release window - #2022
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the release workflow by removing reliance on GitHub鈥檚 compare endpoint for enumerating commits in the release window, instead deriving the commit list locally from the checked-out git history.
Changes:
- Switch release commit enumeration to
git rev-list --reverse <tagSha>..HEADrather thanGET /compare. - Update the release script call sites to use the new
fetchCommitsSinceTag(tagSha)signature (no GitHub client required).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/performRelease/index.ts | Updates callers to use the local commit-window helper (no Octokit client passed). |
| scripts/performRelease/fetchCommitsSinceTag.ts | Replaces GitHub compare API usage with a local git rev-list-based implementation returning a compatible { data: { commits } } shape. |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hshoff
force-pushed
the
harry/visx-release-local-commits
branch
from
June 18, 2026 17:50
a6c6593 to
32a05a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why use local commits for the release window?
The push workflow for PR #2021 still failed in the release step after retrying GitHub's compare endpoint three times.
The workflow checks out full git history with
fetch-depth: '0', so the release script does not need the compare endpoint just to enumerate commit SHAs between the latest reachable tag andHEAD.馃挜 Breaking Changes
馃殌 Enhancements
馃摑 Documentation
馃悰 Bug Fix
git rev-list --reverse <tag>..HEADoutput to build the release commit window instead of fetching the same commit list from GitHub's compare endpoint.馃彔 Internal
Validation
yarn lintgit diff --check