Raise Invalid for non-finite Number values - #543
Closed
CodingFeng101 wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks, but #542 already addresses this and was raised first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #541.
What changed
Numbernow rejects non-finite Decimal values such asInfinityandNaNwithInvalidinstead of leaking the internalTypeErrorfrom precision inspection.Why
Numberis a validator and callers expect validation failures to surface as voluptuousInvalid/MultipleInvalid. Non-finite numeric strings currently escape that contract when precision or scale checking is enabled.Validation
python -m pytest voluptuous\tests\tests.py::test_number_validation_with_string voluptuous\tests\tests.py::test_number_validation_with_non_finite_number voluptuous\tests\tests.py::test_number_validation_with_invalid_precision_invalid_scale -qpython -m pytest voluptuous\tests\tests.py -qpython -m py_compile voluptuous\validators.py voluptuous\tests\tests.pygit diff --check