Implement Ledger support #402
Open
+1,797
−414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 30, 2025 12:31
Solution: Implement Ledger use on CLI to allow using them. Do it importing a specific branch of the SDK.
…nother issue fetching instances from scheduler.
1yam
force-pushed
the
andres-feature-implement_ledger
branch
from
dfd8a03 to
b994c79
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 61.07% 61.25% +0.18%
==========================================
Files 20 20
Lines 3712 3962 +250
Branches 533 581 +48
==========================================
+ Hits 2267 2427 +160
- Misses 1168 1262 +94
+ Partials 277 273 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@1yam how do you use this? I tried |
Update broken doc links and references to old brand names (aleph.im, twentysix.cloud) to aleph.cloud
…older are created
…older are created
…prefetch crn list
… into andres-feature-implement_ledger
nesitor
commented
Nov 20, 2025
| setup_logging(debug) | ||
|
|
||
| account: AccountFromPrivateKey = _load_account(private_key, private_key_file) | ||
| account: AccountTypes = load_account(private_key, private_key_file) |
Member
Author
There was a problem hiding this comment.
Same as above the chain param
Member
There was a problem hiding this comment.
Here the chain args is used to specify a chain where u want to grant permissions
Member
Author
There was a problem hiding this comment.
Yes, and maybe we want to give permissions for Solana wallets.
| setup_logging(debug) | ||
|
|
||
| account: AccountFromPrivateKey = _load_account(private_key, private_key_file) | ||
| account: AccountTypes = load_account(private_key, private_key_file) |
Member
Author
There was a problem hiding this comment.
Same as above the chain param
Member
There was a problem hiding this comment.
Here the chain args is used to specify a chain where u want to grant permissions
nesitor
commented
Nov 21, 2025
Member
Author
nesitor
left a comment
nesitor
left a comment
There was a problem hiding this comment.
In general, I think that ALWAYS we need to take into account the chain parameter as we support non-EVM chains like Solana.
Comment on lines
25
to
27
| settings_link = ( | ||
| f"{sanitize_url(settings.API_HOST)}" | ||
| "/api/v0/aggregates/0xFba561a84A537fCaa567bb7A2257e7142701ae2A.json?keys=settings" | ||
| f"{sanitize_url(settings.API_HOST)}/api/v0/aggregates/0xFba561a84A537fCaa567bb7A2257e7142701ae2A.json?keys=settings" | ||
| ) |
Member
Author
There was a problem hiding this comment.
Nitpick: I think that will be better to put that URL on Settings class
Member
There was a problem hiding this comment.
I think we can let it for now, gonna get removed soon, i started to move that to a custom Services
on sdk side, but didn't got time to finish it yet:
| raise typer.Exit(code=1) from e | ||
| else: | ||
| # Normal flow - show available accounts and let user choose | ||
| accounts = LedgerETHAccount.get_accounts() |
Member
Author
There was a problem hiding this comment.
Here we need to allow also the user to specify how many accounts to get
| derivation_path: Annotated[ | ||
| Optional[str], typer.Option(help="Derivation path for ledger (e.g. \"44'/60'/0'/0/0\")") | ||
| ] = None, | ||
| no: Annotated[bool, typer.Option("--no", help="Non-interactive mode. Only apply provided options.")] = False, |
Member
Author
There was a problem hiding this comment.
Nitpick: I think this param's name can be a bit confusing, maybe something like --non-it or something more explicit.
| setup_logging(debug) | ||
|
|
||
| account: AccountFromPrivateKey = _load_account(private_key, private_key_file) | ||
| account: AccountTypes = load_account(private_key, private_key_file) |
Member
Author
There was a problem hiding this comment.
Yes, but if we allow to use Solana instance on holding tier, and a user wants to add forwarded ports for example, this chain param will be needed.
| setup_logging(debug) | ||
|
|
||
| account: AccountFromPrivateKey = _load_account(private_key, private_key_file) | ||
| account: AccountTypes = load_account(private_key, private_key_file) |
Member
Author
There was a problem hiding this comment.
Yes, and maybe we want to give permissions for Solana wallets.
| setup_logging(debug) | ||
|
|
||
| account: AccountFromPrivateKey = _load_account(private_key, private_key_file) | ||
| account: AccountTypes = load_account(private_key, private_key_file) |
Member
Author
There was a problem hiding this comment.
For FORGET messages we will need to use also the chain argument to forget Solana messages for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Ledger wallet users cannot use Aleph to send transactions.
Solution: Implement Ledger use on CLI to allow using them. Do it importing a specific branch of the SDK.
Self proofreading checklist