refactor: support historical Iceberg snapshot fixtures - #2
Closed
alexanderbianchi wants to merge 1 commit into
Closed
alexanderbianchi wants to merge 1 commit into
alexanderbianchi wants to merge 1 commit into
Conversation
Owner
Author
|
Moved to datafusion-contrib#702 so the stacked PR and both branches live in the OSS repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on datafusion-contrib#700.
Adds
IcebergTestHarnessBuilder::add_snapshot(Snapshot)so tests can construct historical table states at runtime without checking in another metadata JSON fixture. The harness preserves the existing current snapshot while adding the supplied historical snapshots in Iceberg sequence order.The included time-travel regression creates snapshot 42 with deliberately different summary statistics, registers the table with
iceberg.snapshot_id = 42, and demonstrates that statistics currently come from the current snapshot instead.The test is intentionally failing:
datafusion-contrib#687 contains the selected-snapshot fix expected to make this test pass. This draft exists to demonstrate the harness API and provide a meaningful regression test for that change.